[Lens] rewrite BucketNestingEditor tests to use react testing library #199888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
reviewed
Nov 13, 2024
| .first() | ||
| .simulate('click'); | ||
|
|
||
| fireEvent.click(screen.getByTestId('indexPattern-nesting-switch')); |
There was a problem hiding this comment.
Nice improvement!
Would it be possible to make the whole test function async and then use
Suggested change
| fireEvent.click(screen.getByTestId('indexPattern-nesting-switch')); | |
| await userEvent.click(screen.getByTestId('indexPattern-nesting-switch')); |
(same for the other tests that use events)
There was a problem hiding this comment.
They are updated and pass much quicker now:
Thanks! 😊
There was a problem hiding this comment.
Amazing! I'll go ahead and approve it now, thank you for all the hard work 🥇
|
run docs-build |
|
buildkite test this |
mbondyra
changed the title
kyracho
force-pushed
the
rewrite_bucketnestingeditor_tests
branch
from
24ef29d to
e8de359
Compare
mbondyra
approved these changes
Nov 18, 2024
|
run docs-build |
|
buildkite test this |
💚 Build Succeeded
Metrics [docs]
History
|
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
…elastic#199888) ## Summary Hi! This PR rewrites the `BucketNestingEditor` tests to use the react testing library. Fixes elastic#199839 <img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM" src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1"> ### Checklist - [n/a] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Marta Bondyra <[email protected]>
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 25, 2024
…elastic#199888) ## Summary Hi! This PR rewrites the `BucketNestingEditor` tests to use the react testing library. Fixes elastic#199839 <img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM" src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1"> ### Checklist - [n/a] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Marta Bondyra <[email protected]> (cherry picked from commit eddfe5b)
This was referenced Nov 25, 2024
Merged
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 25, 2024
…elastic#199888) ## Summary Hi! This PR rewrites the `BucketNestingEditor` tests to use the react testing library. Fixes elastic#199839 <img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM" src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1"> ### Checklist - [n/a] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Marta Bondyra <[email protected]> (cherry picked from commit eddfe5b)
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
mbondyra
added a commit
that referenced
this pull request
Nov 26, 2024
…ibrary (#199888) (#201529) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)](#199888) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyra Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:46:33Z","message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport missing","💝community","v9.0.0","backport:version"],"number":199888,"url":"https://github.com/elastic/kibana/pull/199888","mergeCommit":{"message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199888","number":199888,"mergeCommit":{"message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}}]}] BACKPORT--> Co-authored-by: Kyra Cho <[email protected]>
mbondyra
added a commit
that referenced
this pull request
Nov 26, 2024
…library (#199888) (#201530) # Backport This will backport the following commits from `main` to `8.17`: - [[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)](#199888) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyra Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:46:33Z","message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport missing","💝community","v9.0.0","backport:version"],"number":199888,"url":"https://github.com/elastic/kibana/pull/199888","mergeCommit":{"message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199888","number":199888,"mergeCommit":{"message":"[Lens] rewrite BucketNestingEditor tests to use react testing library (#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the `BucketNestingEditor` tests to use the react\r\ntesting library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\" alt=\"Screenshot 2024-11-12 at 3 35 06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n### Checklist\r\n\r\n- [n/a] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}}]}] BACKPORT--> Co-authored-by: Kyra Cho <[email protected]>
kibanamachine
added
v8.17.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#199888) ## Summary Hi! This PR rewrites the `BucketNestingEditor` tests to use the react testing library. Fixes elastic#199839 <img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM" src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1"> ### Checklist - [n/a] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This PR rewrites the
BucketNestingEditortests to use the react testing library.Fixes #199839
Checklist