Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Fix button without a11y aria-label #201236

Merged
merged 5 commits into from
Nov 25, 2024
+19 −0
Merged

[Search] Fix button without a11y aria-label #201236

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
496ff5d
[Search] Fix documents count in Search indices page
sphilipse Nov 21, 2024
0e3b664
Fix i18n
sphilipse Nov 21, 2024
5a2bf85
Revert fix
sphilipse Nov 21, 2024
3a69f47
[Search] Add tooltip to explain count discrepancy
sphilipse Nov 25, 2024
90a8352
Merge branch 'main' into es3-fix-documents-count
sphilipse Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/kbn-search-index-documents/components/result/result_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ export const ResultField: React.FC<ResultFieldProps> = ({
<EuiPopover
button={
<EuiButtonIcon
aria-label={i18n.translate(
'searchIndexDocuments.result.fieldTypeButtonAriaLabel',
{
defaultMessage: "Show this field's type",
}
)}
onClick={() => setIsPopoverOpen(!isPopoverOpen)}
iconType={iconType || (fieldType ? iconMap[fieldType] : defaultToken)}
/>
Expand Down
8 changes: 8 additions & 0 deletions x-pack/plugins/search_indices/public/components/quick_stats/quick_stat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
EuiText,
useEuiTheme,
useGeneratedHtmlId,
EuiIconTip,
} from '@elastic/eui';

interface BaseQuickStatProps {
Expand All @@ -33,6 +34,7 @@ interface BaseQuickStatProps {
}>;
setOpen: (open: boolean) => void;
first?: boolean;
tooltipContent?: string;
}

export const QuickStat: React.FC<BaseQuickStatProps> = ({
Expand All @@ -45,6 +47,7 @@ export const QuickStat: React.FC<BaseQuickStatProps> = ({
secondaryTitle,
iconColor,
content,
tooltipContent,
...rest
}) => {
const { euiTheme } = useEuiTheme();
Expand Down Expand Up @@ -93,6 +96,11 @@ export const QuickStat: React.FC<BaseQuickStatProps> = ({
{secondaryTitle}
</EuiText>
</EuiFlexItem>
{tooltipContent && (
<EuiFlexItem>
<EuiIconTip content={tooltipContent} />
</EuiFlexItem>
)}
</EuiFlexGroup>
</EuiPanel>
}
Expand Down
5 changes: 5 additions & 0 deletions x-pack/plugins/search_indices/public/components/quick_stats/quick_stats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export interface QuickStatsProps {
index: Index;
mappings: Mappings;
indexDocuments: IndexDocuments;
tooltipContent?: string;
}

export const SetupAISearchButton: React.FC = () => {
Expand Down Expand Up @@ -107,6 +108,10 @@ export const QuickStats: React.FC<QuickStatsProps> = ({ index, mappings, indexDo
description: index.size ?? '0b',
},
]}
tooltipContent={i18n.translate('xpack.searchIndices.quickStats.documentCountTooltip', {
defaultMessage:
'This excludes nested documents, which Elasticsearch uses internally to store chunks of vectors.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'This excludes nested documents, which Elasticsearch uses internally to store chunks of vectors.',
'This excludes nested documents, which semantic_text uses internally to store chunks of vectors.',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make this wider than just because we also use that for more manual vector ingestion.

})}
first
/>
</EuiFlexItem>
Expand Down