[Search] Fix button without a11y aria-label #201236
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
x-pack/plugins/search_indices/public/components/quick_stats/quick_stats.tsx
Outdated
Show resolved
Hide resolved
sphilipse
changed the title
joemcelroy
reviewed
Nov 25, 2024
| @@ -107,6 +108,10 @@ export const QuickStats: React.FC<QuickStatsProps> = ({ index, mappings, indexDo | |||
| description: index.size ?? '0b', | |||
| }, | |||
| ]} | |||
| tooltipContent={i18n.translate('xpack.searchIndices.quickStats.documentCountTooltip', { | |||
| defaultMessage: | |||
| 'This excludes nested documents, which Elasticsearch uses internally to store chunks of vectors.', | |||
There was a problem hiding this comment.
Suggested change
| 'This excludes nested documents, which Elasticsearch uses internally to store chunks of vectors.', | |
| 'This excludes nested documents, which semantic_text uses internally to store chunks of vectors.', |
There was a problem hiding this comment.
I wanted to make this wider than just because we also use that for more manual vector ingestion.
joemcelroy
approved these changes
Nov 25, 2024
|
Starting backport for target branches: 8.17 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
Also adds a tooltip to the document count to explain why the count might differ. (cherry picked from commit 77f0854)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[Search] Fix button without a11y aria-label (#201236)](#201236) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T16:22:16Z","message":"[Search] Fix button without a11y aria-label (#201236)\n\nAlso adds a tooltip to the document count to explain why the count might differ.","sha":"77f08541e146ac071d18d1df52b2ab6284608df7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0"],"title":"[Search] Fix button without a11y aria-label","number":201236,"url":"https://github.com/elastic/kibana/pull/201236","mergeCommit":{"message":"[Search] Fix button without a11y aria-label (#201236)\n\nAlso adds a tooltip to the document count to explain why the count might differ.","sha":"77f08541e146ac071d18d1df52b2ab6284608df7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201236","number":201236,"mergeCommit":{"message":"[Search] Fix button without a11y aria-label (#201236)\n\nAlso adds a tooltip to the document count to explain why the count might differ.","sha":"77f08541e146ac071d18d1df52b2ab6284608df7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
Also adds a tooltip to the document count to explain why the count might differ.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Also adds a tooltip to the document count to explain why the count might differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small A11y fix.