Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] Remove Actions tooltip #201231

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[Inventory] Remove Actions tooltip #201231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
400539f
refactor: remove actions tooltip
rmyz Nov 21, 2024
5e635cc
chore: fix small typo
rmyz Nov 21, 2024
6f2e28f
fix: fix translations typo
rmyz Nov 22, 2024
39ccc44
Merge branch 'main' into 199500-inventory-remove-actions-tooltip
rmyz Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ export const getColumns = ({
id: 'actions' as const,
// keep it for accessibility purposes
displayAsText: entityActionsLabel,
display: (
<CustomHeaderCell title={entityActionsLabel} tooltipContent={entityActionsLabel} />
),
display: <span>{entityActionsLabel}</span>,
initialWidth: 100,
},
]
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export function EntitiesGrid({
<EuiText size="s">
<FormattedMessage
id="xpack.inventory.entitiesGrid.euiDataGrid.headerLeft"
defaultMessage="Showing {currentItems} of {total} {boldEntites}"
defaultMessage="Showing {currentItems} of {total} {boldEntities}"
values={{
currentItems: (
<strong>
Expand All @@ -169,10 +169,10 @@ export function EntitiesGrid({
</strong>
),
total: entities.length,
boldEntites: (
boldEntities: (
<strong>
{i18n.translate(
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites',
'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities',
{ defaultMessage: 'Entities' }
)}
</strong>
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26176,8 +26176,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "Le nombre d'alertes actives",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "Nom de l'entité",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "Nom de l'entité (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "Entités",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "Grille des entités d'inventaire",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} à {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "Vu en dernier",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26148,8 +26148,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "アクティブなアラートの件数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "エンティティ名",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "エンティティの名前（entity.displayName）",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntites}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntities}を表示中",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "エンティティ",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "インベントリエンティティグリッド",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "前回の認識",
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25678,8 +25678,8 @@
"xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "活动告警计数",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "实体名称",
"xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "实体的名称 (entity.displayName)",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntites}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntities}",
"xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "实体",
"xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "库存实体网格",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}",
"xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "最后看到时间",
Expand Down