Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] Remove Actions tooltip #201231

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Nov 21, 2024

Summary

Closes #199500

This PR removes the Actions tooltip in the Entities Table.

Screenshots

Before After
image image

How to test

  1. Go to Inventory
  2. Check the columns of the Entities table, the tooltip + help button should now be gone.

@rmyz rmyz self-assigned this Nov 21, 2024
@rmyz rmyz requested a review from a team as a code owner November 21, 2024 16:03
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 21, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@rmyz rmyz added release_note:fix backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed ci:project-deploy-observability Create an Observability project labels Nov 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Nov 21, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 21, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 22, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 39ccc44
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201231-39ccc44920de

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 236.3KB 236.3KB -14.0B

History

cc @rmyz

@rmyz rmyz merged commit 62fad39 into elastic:main Nov 22, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11972593997

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 22, 2024
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.

(cherry picked from commit 62fad39)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 22, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Remove &#x60;Actions&#x60; tooltip
(#201231)](#201231)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T12:29:37Z","message":"[Inventory]
Remove `Actions` tooltip (#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[Inventory]
Remove `Actions`
tooltip","number":201231,"url":"https://github.com/elastic/kibana/pull/201231","mergeCommit":{"message":"[Inventory]
Remove `Actions` tooltip (#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201231","number":201231,"mergeCommit":{"message":"[Inventory]
Remove `Actions` tooltip (#201231)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199500\n\nThis PR removes the
Actions tooltip in the Entities Table.\n\n## Screenshots\n| Before |
After
|\n\n|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|\n\n|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img\nwidth=\"1441\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438\">|\n\n##
How to test\n1. Go to Inventory\n2. Check the columns of the Entities
table, the tooltip + help button\nshould now be
gone.","sha":"62fad394e131e3629e1252cb6d28b9df8eff004b"}}]}] BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Closes elastic#199500

This PR removes the Actions tooltip in the Entities Table.

## Screenshots
| Before | After |

|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------|

|![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|<img
width="1441" alt="image"
src="https://github.com/user-attachments/assets/29884aa1-3d82-4e0e-ae88-222fc8edf438">|

## How to test
1. Go to Inventory
2. Check the columns of the Entities table, the tooltip + help button
should now be gone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inventory] Remove tooltip message for the action column
4 participants