Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the reason for skipped APM tests #201214

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon

let apmSynthtraceEsClient: ApmSynthtraceEsClient;

describe('Diagnostics: Indices', () => {
describe.skip('When there is no data', () => {
it('returns empty response`', async () => {
// Failing tests were skipped because the current solution for verifying ingest pipelines needs improvement
describe.skip('Diagnostics: Indices', () => {
describe('When there is no data', () => {
it('returns empty response', async () => {
const { status, body } = await apmApiClient.adminUser({
endpoint: 'GET /internal/apm/diagnostics',
});
Expand All @@ -34,7 +35,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});
});

describe.skip('When data is ingested', () => {
describe('When data is ingested', () => {
before(async () => {
const instance = apm
.service({ name: 'synth-go', environment: 'production', agentName: 'go' })
Expand Down Expand Up @@ -68,7 +69,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});
});

describe.skip('When data is ingested without the necessary index templates', () => {
describe('When data is ingested without the necessary index templates', () => {
before(async () => {
await es.indices.deleteDataStream({ name: 'traces-apm-*' });
await es.indices.deleteIndexTemplate({ name: ['traces-apm'] });
Expand Down Expand Up @@ -114,7 +115,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});
});

describe.skip('ingest pipelines', () => {
describe('ingest pipelines', () => {
before(async () => {
const instance = apm
.service({ name: 'synth-go', environment: 'production', agentName: 'go' })
Expand All @@ -138,7 +139,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
await apmSynthtraceEsClient.clean();
});

describe.skip('an ingest pipeline is removed', () => {
describe('an ingest pipeline is removed', () => {
before(async () => {
const datastreamToUpdate = await es.indices.getDataStream({
name: 'metrics-apm.internal-default',
Expand Down Expand Up @@ -168,7 +169,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});
});

describe.skip('an ingest pipeline is changed', () => {
describe('an ingest pipeline is changed', () => {
before(async () => {
const datastreamToUpdate = await es.indices.getDataStream({
name: 'metrics-apm.internal-default',
Expand Down