Document the reason for skipped APM tests #201214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszmarcinkowski
added
release_note:skip
miloszmarcinkowski
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
Closes elastic#199843 ### Summary This PR documents the reason for skipped Indices diagnostics API tests to avoid confusion in the future. APM diagnostics is an experimental internal tool. Indices diagnostics determine whether ingest pipelines were installed correctly by verifying the presence of the `observer.version` field in grok processor, this approach isn't reliable anymore. We should consider implementing improvement or sunsetting the feature if there is no maintainer. (cherry picked from commit fb35ae4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Document the reason for skipped APM tests (#201214)](#201214) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:37:05Z","message":"Document the reason for skipped APM tests (#201214)\n\nCloses #199843\r\n\r\n### Summary\r\n\r\nThis PR documents the reason for skipped Indices diagnostics API tests\r\nto avoid confusion in the future. APM diagnostics is an experimental\r\ninternal tool. Indices diagnostics determine whether ingest pipelines\r\nwere installed correctly by verifying the presence of the\r\n`observer.version` field in grok processor, this approach isn't reliable\r\nanymore. We should consider implementing improvement or sunsetting the\r\nfeature if there is no maintainer.","sha":"fb35ae45df41b324a53669a735779b15d30f332f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Document the reason for skipped APM tests","number":201214,"url":"https://github.com/elastic/kibana/pull/201214","mergeCommit":{"message":"Document the reason for skipped APM tests (#201214)\n\nCloses #199843\r\n\r\n### Summary\r\n\r\nThis PR documents the reason for skipped Indices diagnostics API tests\r\nto avoid confusion in the future. APM diagnostics is an experimental\r\ninternal tool. Indices diagnostics determine whether ingest pipelines\r\nwere installed correctly by verifying the presence of the\r\n`observer.version` field in grok processor, this approach isn't reliable\r\nanymore. We should consider implementing improvement or sunsetting the\r\nfeature if there is no maintainer.","sha":"fb35ae45df41b324a53669a735779b15d30f332f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201214","number":201214,"mergeCommit":{"message":"Document the reason for skipped APM tests (#201214)\n\nCloses #199843\r\n\r\n### Summary\r\n\r\nThis PR documents the reason for skipped Indices diagnostics API tests\r\nto avoid confusion in the future. APM diagnostics is an experimental\r\ninternal tool. Indices diagnostics determine whether ingest pipelines\r\nwere installed correctly by verifying the presence of the\r\n`observer.version` field in grok processor, this approach isn't reliable\r\nanymore. We should consider implementing improvement or sunsetting the\r\nfeature if there is no maintainer.","sha":"fb35ae45df41b324a53669a735779b15d30f332f"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
Closes elastic#199843 ### Summary This PR documents the reason for skipped Indices diagnostics API tests to avoid confusion in the future. APM diagnostics is an experimental internal tool. Indices diagnostics determine whether ingest pipelines were installed correctly by verifying the presence of the `observer.version` field in grok processor, this approach isn't reliable anymore. We should consider implementing improvement or sunsetting the feature if there is no maintainer.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Closes elastic#199843 ### Summary This PR documents the reason for skipped Indices diagnostics API tests to avoid confusion in the future. APM diagnostics is an experimental internal tool. Indices diagnostics determine whether ingest pipelines were installed correctly by verifying the presence of the `observer.version` field in grok processor, this approach isn't reliable anymore. We should consider implementing improvement or sunsetting the feature if there is no maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199843
Summary
This PR documents the reason for skipped Indices diagnostics API tests to avoid confusion in the future. APM diagnostics is an experimental internal tool. Indices diagnostics determine whether ingest pipelines were installed correctly by verifying the presence of the
observer.versionfield in grok processor, this approach isn't reliable anymore. We should consider implementing improvement or sunsetting the feature if there is no maintainer.