Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] Sort asset criticality by @timestamp by default + unskip serverless tests #200712

Merged
merged 4 commits into from
Nov 20, 2024
Merged

[Entity Analytics] Sort asset criticality by @timestamp by default + unskip serverless tests #200712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e564897
fix asset criticality tests by adding default sort order
hop-dev Nov 19, 2024
21f9eb6
unskip risk scoring task test
hop-dev Nov 19, 2024
d5e98e6
remove .only
hop-dev Nov 19, 2024
5e7edfd
add comment
hop-dev Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...y_solution/server/lib/entity_analytics/asset_criticality/asset_criticality_data_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class AssetCriticalityDataClient {
query,
size = DEFAULT_CRITICALITY_RESPONSE_SIZE,
from,
sort,
sort = ['@timestamp'], // without a default sort order the results are not deterministic which makes testing hard
}: {
query: ESFilter;
size?: number;
Expand Down
6 changes: 3 additions & 3 deletions ...test_suites/entity_analytics/risk_engine/trial_license_complete_tier/asset_criticality.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export default ({ getService }: FtrProviderContext) => {

const createRecords = () => createAssetCriticalityRecords(records, es);

it('@skipInServerless should return the first 10 asset criticality records if no args provided', async () => {
it(' should return the first 10 asset criticality records if no args provided', async () => {
await createRecords();

const { body } = await assetCriticalityRoutes.list();
Expand Down Expand Up @@ -259,7 +259,7 @@ export default ({ getService }: FtrProviderContext) => {
);
});

it('@skipInServerless should only return 1 asset criticality record if per_page=1', async () => {
it('should only return 1 asset criticality record if per_page=1', async () => {
await createRecords();

const { body } = await assetCriticalityRoutes.list({ per_page: 1 });
Expand All @@ -273,7 +273,7 @@ export default ({ getService }: FtrProviderContext) => {
expect(body.records[0].id_value).to.eql(records[0].id_value);
});

it('@skipInServerless should return the next 10 asset criticality records if page=2', async () => {
it('should return the next 10 asset criticality records if page=2', async () => {
await createRecords();

const { body } = await assetCriticalityRoutes.list({ page: 2 });
Expand Down
2 changes: 1 addition & 1 deletion ...ity_analytics/risk_engine/trial_license_complete_tier/risk_scoring_task/task_execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default ({ getService }: FtrProviderContext): void => {
);
});

it('@skipInServerlessMKI @skipInServerless starts the latest transform', async () => {
it('@skipInServerlessMKI starts the latest transform', async () => {
// Transform states that indicate the transform is running happily
const TRANSFORM_STARTED_STATES = ['started', 'indexing'];

Expand Down