Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Entity Analytics] Sort asset criticality by @timestamp by default + unskip serverless tests #200712

Merged
merged 4 commits into from
Nov 20, 2024
Merged

[Entity Analytics] Sort asset criticality by @timestamp by default + unskip serverless tests #200712

merged 4 commits into from
Nov 20, 2024
+5 −5

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Nov 19, 2024 •
edited by kibanamachine
Loading

Summary

Closes #189067

These asset criticality tests were failing in serverless because it seems queries without a specified sort order behave differently in serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default, this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the better.

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Entity Analytics Security Entity Analytics Team backport:version Backport to applied version labels v8.17.0 v8.16.1 v8.18.0 labels Nov 19, 2024
@hop-dev hop-dev self-assigned this Nov 19, 2024
@hop-dev hop-dev requested a review from a team as a code owner November 19, 2024 11:55
@hop-dev hop-dev requested a review from tiansivive November 19, 2024 11:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

hop-dev
hop-dev commented Nov 19, 2024
View reviewed changes
...entity_analytics/risk_engine/trial_license_complete_tier/risk_scoring_task/task_execution.ts Outdated
@@ -103,7 +103,7 @@ export default ({ getService }: FtrProviderContext): void => {
);
});

it('@skipInServerlessMKI @skipInServerless starts the latest transform', async () => {
it.only('@skipInServerlessMKI starts the latest transform', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't fail in serverless for me, lets see what CI does, I think it was skipped in error.

@hop-dev hop-dev requested a review from tiansivive November 20, 2024 14:06
@hop-dev hop-dev enabled auto-merge (squash) November 20, 2024 14:06
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @hop-dev

tiansivive
tiansivive approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hop-dev hop-dev merged commit 4c29589 into elastic:main Nov 20, 2024
43 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11937595086

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@hop-dev
[Entity Analytics] Sort asset criticality by @timestamp by default …
72bb1f0 
…+ unskip serverless tests (elastic#200712)

## Summary

Closes elastic#189067

These asset criticality tests were failing in serverless because it
seems queries without a specified sort order behave differently in
serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default,
this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the
better.

(cherry picked from commit 4c29589)
@kibanamachine kibanamachine mentioned this pull request Nov 20, 2024
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@hop-dev
[Entity Analytics] Sort asset criticality by @timestamp by default …
2fdda4b 
…+ unskip serverless tests (elastic#200712)

## Summary

Closes elastic#189067

These asset criticality tests were failing in serverless because it
seems queries without a specified sort order behave differently in
serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default,
this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the
better.

(cherry picked from commit 4c29589)
@kibanamachine kibanamachine mentioned this pull request Nov 20, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.16
❌ 8.18 The branch "8.18" does not exist
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 200712

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
@kibanamachine @hop-dev
[8.x] [Entity Analytics] Sort asset criticality by `@timestamp&#…
e40f09d 
…x60; by default + unskip serverless tests (#200712) (#200992)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Entity Analytics] Sort asset criticality by `@timestamp`
by default + unskip serverless tests
(#200712)](#200712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mark
Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T16:27:42Z","message":"[Entity
Analytics] Sort asset criticality by `@timestamp` by default + unskip
serverless tests (#200712)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/189067\n\nThese asset
criticality tests were failing in serverless because it\nseems queries
without a specified sort order behave differently in\nserverless vs
ESS.\n\nI have made it so that asset criticality sorts by timestamp by
default,\nthis makes serverless the same as ESS.\n\nI have backported to
8.16 as I think the more tests that run,
the\nbetter.","sha":"4c295893ba8ead829c1f0ad01c9d46741420d66f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Entity
Analytics","backport:version","v8.17.0","v8.16.1","v8.18.0"],"title":"[Entity
Analytics] Sort asset criticality by `@timestamp` by default + unskip
serverless
tests","number":200712,"url":"https://github.com/elastic/kibana/pull/200712","mergeCommit":{"message":"[Entity
Analytics] Sort asset criticality by `@timestamp` by default + unskip
serverless tests (#200712)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/189067\n\nThese asset
criticality tests were failing in serverless because it\nseems queries
without a specified sort order behave differently in\nserverless vs
ESS.\n\nI have made it so that asset criticality sorts by timestamp by
default,\nthis makes serverless the same as ESS.\n\nI have backported to
8.16 as I think the more tests that run,
the\nbetter.","sha":"4c295893ba8ead829c1f0ad01c9d46741420d66f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200712","number":200712,"mergeCommit":{"message":"[Entity
Analytics] Sort asset criticality by `@timestamp` by default + unskip
serverless tests (#200712)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/189067\n\nThese asset
criticality tests were failing in serverless because it\nseems queries
without a specified sort order behave differently in\nserverless vs
ESS.\n\nI have made it so that asset criticality sorts by timestamp by
default,\nthis makes serverless the same as ESS.\n\nI have backported to
8.16 as I think the more tests that run,
the\nbetter.","sha":"4c295893ba8ead829c1f0ad01c9d46741420d66f"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Mark Hopkin <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 21, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
@hop-dev @TattdCodeMonkey
[Entity Analytics] Sort asset criticality by @timestamp by default …
76afa26 
…+ unskip serverless tests (elastic#200712)

## Summary

Closes elastic#189067

These asset criticality tests were failing in serverless because it
seems queries without a specified sort order behave differently in
serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default,
this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the
better.
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@hop-dev hop-dev removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.18.0 labels Nov 25, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@hop-dev @paulinashakirova
[Entity Analytics] Sort asset criticality by @timestamp by default …
e0e9c64 
…+ unskip serverless tests (elastic#200712)

## Summary

Closes elastic#189067

These asset criticality tests were failing in serverless because it
seems queries without a specified sort order behave differently in
serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default,
this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the
better.
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@hop-dev hop-dev added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Nov 27, 2024
@hop-dev hop-dev deleted the fix-serverless-tests branch November 27, 2024 10:52
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@hop-dev @CAWilson94
[Entity Analytics] Sort asset criticality by @timestamp by default …
64274fe 
…+ unskip serverless tests (elastic#200712)

## Summary

Closes elastic#189067

These asset criticality tests were failing in serverless because it
seems queries without a specified sort order behave differently in
serverless vs ESS.

I have made it so that asset criticality sorts by timestamp by default,
this makes serverless the same as ESS.

I have backported to 8.16 as I think the more tests that run, the
better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiansivive tiansivive tiansivive approved these changes

Assignees

@hop-dev hop-dev

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.1 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Fix and unskip Asset Criticality API tests in serverless
4 participants
@hop-dev @elasticmachine @kibanamachine @tiansivive