Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the callout for upgrading to get enterprise-level features #200283

Merged
merged 4 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { shallow } from 'enzyme';

import { ErrorStateCallout } from '../../../shared/error_state';

import { SetupGuideCta } from '../setup_guide';
import { TrialCallout } from '../trial_callout';

import { ElasticsearchProductCard } from './elasticsearch_product_card';
Expand All @@ -26,7 +25,6 @@ describe('ProductSelector', () => {
const wrapper = shallow(<ProductSelector />);

expect(wrapper.find(ElasticsearchProductCard)).toHaveLength(1);
expect(wrapper.find(SetupGuideCta)).toHaveLength(1);
});

it('renders the trial callout', () => {
Expand Down Expand Up @@ -62,14 +60,12 @@ describe('ProductSelector', () => {
const wrapper = shallow(<ProductSelector />);

expect(wrapper.find(ElasticsearchProductCard)).toHaveLength(1);
expect(wrapper.find(SetupGuideCta)).toHaveLength(0);
});

it('does not render EnterpriseSearch card without access', () => {
const wrapper = shallow(<ProductSelector />);

expect(wrapper.find(ElasticsearchProductCard)).toHaveLength(1);
expect(wrapper.find(SetupGuideCta)).toHaveLength(0);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import { SendEnterpriseSearchTelemetry as SendTelemetry } from '../../../shared/
import headerImage from '../../assets/search_header.png';

import { EnterpriseSearchOverviewPageTemplate } from '../layout';
import { SetupGuideCta } from '../setup_guide';
import { TrialCallout } from '../trial_callout';

import { ElasticsearchProductCard } from './elasticsearch_product_card';
Expand Down Expand Up @@ -121,11 +120,6 @@ export const ProductSelector: React.FC = () => {
<EuiFlexItem>
<SearchLabsBanner />
</EuiFlexItem>
{!config.host && config.canDeployEntSearch && (
<EuiFlexItem>
<SetupGuideCta />
</EuiFlexItem>
)}
</EuiFlexGroup>
</EuiPageTemplate.Section>
</EnterpriseSearchOverviewPageTemplate>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@
*/

export { SetupGuide } from './setup_guide';
export { SetupGuideCta } from './setup_guide_cta';

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -18593,7 +18593,6 @@
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.description": "Envoyez une requête de test pour confirmer que votre client de langage et votre instance Elasticsearch sont opérationnels.",
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.title": "Tester votre connexion",
"xpack.enterpriseSearch.overview.navTitle": "Aperçu",
"xpack.enterpriseSearch.overview.setupCta.description": "Ajoutez des fonctions de recherche à votre application ou à votre organisation interne avec Elastic App Search et Workplace Search. Regardez la vidéo pour savoir ce qu'il est possible de faire lorsque la recherche est facilitée.",
"xpack.enterpriseSearch.pageTemplate.endpointsButtonLabel": "Points de terminaison et clés d'API",
"xpack.enterpriseSearch.passwordLabel": "Mot de passe",
"xpack.enterpriseSearch.pipeline.title": "Transformer et enrichir vos données",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -18565,7 +18565,6 @@
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.description": "テストリクエストを送信して、言語クライアントとElasticsearchインスタンスが起動し、実行中であることを確認してください。",
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.title": "接続をテスト",
"xpack.enterpriseSearch.overview.navTitle": "概要",
"xpack.enterpriseSearch.overview.setupCta.description": "Elastic App Search および Workplace Search を使用して、アプリまたは社内組織に検索を追加できます。検索が簡単になるとどのような利点があるのかについては、動画をご覧ください。",
"xpack.enterpriseSearch.pageTemplate.endpointsButtonLabel": "エンドポイントとAPIキー",
"xpack.enterpriseSearch.passwordLabel": "パスワード",
"xpack.enterpriseSearch.pipeline.title": "データの変換とエンリッチ",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -18229,7 +18229,6 @@
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.description": "发送测试请求,以确认您的语言客户端和 Elasticsearch 实例已启动并正在运行。",
"xpack.enterpriseSearch.overview.gettingStarted.testConnection.title": "测试您的连接",
"xpack.enterpriseSearch.overview.navTitle": "概览",
"xpack.enterpriseSearch.overview.setupCta.description": "通过 Elastic App Search 和 Workplace Search,将搜索添加到您的应用或内部组织中。观看视频,了解方便易用的搜索功能可以帮您做些什么。",
"xpack.enterpriseSearch.pageTemplate.endpointsButtonLabel": "终端和 API 密钥",
"xpack.enterpriseSearch.passwordLabel": "密码",
"xpack.enterpriseSearch.pipeline.title": "转换和扩充数据",
Expand Down
9 changes: 0 additions & 9 deletions x-pack/test/accessibility/apps/group3/enterprise_search.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
await a11y.testAppSnapshot();
});

it('loads a setup guide', async function () {
await testSubjects.click('setupGuideLink');
await retry.waitFor(
'setup guide visible',
async () => await testSubjects.exists('setupGuide')
);
await a11y.testAppSnapshot();
});
});

describe('Content', () => {
Expand Down