Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the callout for upgrading to get enterprise-level features #200283

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Remove the callout for upgrading to get enterprise-level features #200283

merged 4 commits into from
Nov 21, 2024

Conversation

saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Nov 14, 2024 •
edited
Loading

This PR resolves this issue.

Before

Screenshot 2024-11-14 at 4 52 14 PM

After

Screenshot 2024-11-14 at 4 52 55 PM

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner November 14, 2024 23:59
@saikatsarkar056 saikatsarkar056 marked this pull request as draft November 14, 2024 23:59
@saikatsarkar056 saikatsarkar056 self-assigned this Nov 15, 2024
@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review November 18, 2024 21:17
@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner November 18, 2024 21:17
@saikatsarkar056 saikatsarkar056 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 18, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / #getDataUsageMetricsFiltersFromUrlParams should use given relative startDate and endDate values URL params

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2319 2312 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -4.3KB

History

cc @saikatsarkar056

mdefazio
mdefazio approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikatsarkar056 saikatsarkar056 merged commit e378c88 into elastic:main Nov 21, 2024
23 checks passed
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@saikatsarkar056 @paulinashakirova
Remove the callout for upgrading to get enterprise-level features (el…
bebdd9b 
…astic#200283)

This PR resolves this
[issue](elastic/search-team#8523).

### Before
<img width="1152" alt="Screenshot 2024-11-14 at 4 52 14 PM"
src="https://github.com/user-attachments/assets/77e74017-1708-40c3-b4a1-4fcbaf77ef48">


### After
<img width="1153" alt="Screenshot 2024-11-14 at 4 52 55 PM"
src="https://github.com/user-attachments/assets/5e8f8ba4-2269-4a06-885b-ec43aa9c7f40">
@kibanamachine kibanamachine mentioned this pull request Nov 27, 2024
Merged
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@saikatsarkar056 @CAWilson94
Remove the callout for upgrading to get enterprise-level features (el…
2b3c769 
…astic#200283)

This PR resolves this
[issue](elastic/search-team#8523).

### Before
<img width="1152" alt="Screenshot 2024-11-14 at 4 52 14 PM"
src="https://github.com/user-attachments/assets/77e74017-1708-40c3-b4a1-4fcbaf77ef48">


### After
<img width="1153" alt="Screenshot 2024-11-14 at 4 52 55 PM"
src="https://github.com/user-attachments/assets/5e8f8ba4-2269-4a06-885b-ec43aa9c7f40">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@mdefazio mdefazio mdefazio approved these changes

@TattdCodeMonkey TattdCodeMonkey Awaiting requested review from TattdCodeMonkey

Assignees

@saikatsarkar056 saikatsarkar056

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saikatsarkar056 @elasticmachine @mdefazio @sphilipse @kibanamachine