Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ownership] Assign test files to data discovery team #200132

Merged
merged 6 commits into from
Nov 19, 2024
Merged

[Ownership] Assign test files to data discovery team #200132

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a51694
[Ownership] Assign test files to data discovery team
wayneseymour Nov 14, 2024
61a6a8d
Update .github/CODEOWNERS
wayneseymour Nov 18, 2024
3feaac5
Merge branch 'main' of github.com:elastic/kibana into assign-data-dis…
wayneseymour Nov 18, 2024
85292c5
drop
wayneseymour Nov 18, 2024
7a8322c
simplify per cr
wayneseymour Nov 18, 2024
e1ecda3
Update .github/CODEOWNERS
wayneseymour Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,9 +1038,23 @@ x-pack/test_serverless/api_integration/test_suites/common/platform_security @ela
/x-pack/plugins/entity_manager @elastic/obs-entities
/x-pack/test/api_integration/apis/entity_manager @elastic/obs-entities


# Data Discovery
/test/plugin_functional/plugins/data_search @elastic/kibana-data-discovery
/test/functional/fixtures/es_archiver/alias @elastic/kibana-data-discovery
/test/functional/page_objects/context_page.ts @elastic/kibana-data-discovery
/test/functional/services/data_views.ts @elastic/kibana-data-discovery
/test/functional/services/saved_objects_finder.ts @elastic/kibana-data-discovery
/test/functional/page_objects/unified_search_page.ts @elastic/kibana-data-discovery
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/plugin_functional/plugins/index_patterns @elastic/kibana-data-discovery
/test/plugin_functional/plugins/data_search @elastic/kibana-data-discovery
/test/functional/page_objects/discover_page.ts @elastic/kibana-data-discovery
/test/functional/fixtures/es_archiver/index_pattern_without_timefield @elastic/kibana-data-discovery
/test/functional/fixtures/es_archiver/huge_fields @elastic/kibana-data-discovery
/test/functional/fixtures/es_archiver/date_n* @elastic/kibana-data-discovery
/test/functional/firefox/discover.config.ts @elastic/kibana-data-discovery
/test/functional/fixtures/es_archiver/discover/**/*.ts @elastic/kibana-data-discovery
wayneseymour marked this conversation as resolved.
Show resolved Hide resolved
/test/api_integration/apis/suggestions @elastic/kibana-data-discovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/test/api_integration/apis/suggestions @elastic/kibana-data-discovery
/test/api_integration/apis/suggestions @elastic/kibana-visualizations

As of now UnifiedSearch is owned by the Visualizations team. Same for /test/functional/page_objects/unified_search_page.ts.

@davismcphee Or would you be fine with assigning it to us?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest assigning it to @elastic/kibana-visualizations for now to keep things simpler. If it exchanges ownership in the future, we can reassign the test files too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85292c5

/test/api_integration/apis/saved_queries/*.ts @elastic/kibana-data-discovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/test/api_integration/apis/saved_queries/*.ts @elastic/kibana-data-discovery
/test/api_integration/apis/saved_queries @elastic/kibana-data-discovery

Can we simplify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7a8322c

/x-pack/test/api_integration/apis/kibana/kql_telemetry @elastic/kibana-data-discovery @elastic/kibana-visualizations
/x-pack/test_serverless/functional/es_archives/pre_calculated_histogram @elastic/kibana-data-discovery
/x-pack/test_serverless/functional/es_archives/kibana_sample_data_flights_index_pattern @elastic/kibana-data-discovery
Expand Down