[Ownership] Assign test files to data discovery team #200132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
jughosta
reviewed
Nov 14, 2024
.github/CODEOWNERS
Outdated
| /test/functional/fixtures/es_archiver/date_n* @elastic/kibana-data-discovery | ||
| /test/functional/firefox/discover.config.ts @elastic/kibana-data-discovery | ||
| /test/functional/fixtures/es_archiver/discover/**/*.ts @elastic/kibana-data-discovery | ||
| /test/api_integration/apis/suggestions @elastic/kibana-data-discovery |
There was a problem hiding this comment.
Suggested change
| /test/api_integration/apis/suggestions @elastic/kibana-data-discovery | |
| /test/api_integration/apis/suggestions @elastic/kibana-visualizations |
As of now UnifiedSearch is owned by the Visualizations team. Same for /test/functional/page_objects/unified_search_page.ts.
@davismcphee Or would you be fine with assigning it to us?
There was a problem hiding this comment.
I'd suggest assigning it to @elastic/kibana-visualizations for now to keep things simpler. If it exchanges ownership in the future, we can reassign the test files too.
.github/CODEOWNERS
Outdated
| /test/functional/firefox/discover.config.ts @elastic/kibana-data-discovery | ||
| /test/functional/fixtures/es_archiver/discover/**/*.ts @elastic/kibana-data-discovery | ||
| /test/api_integration/apis/suggestions @elastic/kibana-data-discovery | ||
| /test/api_integration/apis/saved_queries/*.ts @elastic/kibana-data-discovery |
There was a problem hiding this comment.
Suggested change
| /test/api_integration/apis/saved_queries/*.ts @elastic/kibana-data-discovery | |
| /test/api_integration/apis/saved_queries @elastic/kibana-data-discovery |
Can we simplify?
Co-authored-by: Julia Rechkunova <[email protected]>
💚 Build Succeeded
Metrics [docs]
History
|
davismcphee
reviewed
Nov 18, 2024
Co-authored-by: Davis McPhee <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
## Summary Assign test files to data discovery team Contributes to: elastic#192979 --------- Co-authored-by: Julia Rechkunova <[email protected]> Co-authored-by: Davis McPhee <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Assign test files to data discovery team Contributes to: elastic#192979 --------- Co-authored-by: Julia Rechkunova <[email protected]> Co-authored-by: Davis McPhee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assign test files to data discovery team
Contributes to: #192979