Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Mgmt] Improve accessibility of templates table #199980

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[Index Mgmt] Improve accessibility of templates table #199980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a78b1f9
[Index Mgmt] Improve accessibility of templates table
sphilipse Nov 13, 2024
ae8a84c
Fix i18n
sphilipse Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 44 additions & 19 deletions ...management/public/application/components/shared/components/template_content_indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,46 +16,71 @@ interface Props {
contentWhenEmpty?: JSX.Element | null;
}

const texts = {
settings: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexSettingsTooltipLabel', {
defaultMessage: 'Index settings',
}),
mappings: i18n.translate('xpack.idxMgmt.templateContentIndicator.mappingsTooltipLabel', {
defaultMessage: 'Mappings',
}),
aliases: i18n.translate('xpack.idxMgmt.templateContentIndicator.aliasesTooltipLabel', {
defaultMessage: 'Aliases',
}),
};
const getColor = (flag: boolean) => (flag ? 'primary' : 'hollow');

export const TemplateContentIndicator = ({
mappings,
settings,
aliases,
contentWhenEmpty = null,
}: Props) => {
const getColor = (flag: boolean) => (flag ? 'primary' : 'hollow');

if (!mappings && !settings && !aliases) {
return contentWhenEmpty;
}

const texts = {
settingsTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexSettingsTrueLabel', {
defaultMessage: 'This template contains index settings',
}),
settingsFalse: i18n.translate(
'xpack.idxMgmt.templateContentIndicator.indexSettingsFalseLabel',
{
defaultMessage: 'This template does not contain index settings',
}
),
mappingsTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexMappingsTrueLabel', {
defaultMessage: 'This template contains index mappings',
}),
mappingsFalse: i18n.translate(
'xpack.idxMgmt.templateContentIndicator.indexMappingsFalseLabel',
{
defaultMessage: 'This template does not contain index mappings',
}
),
aliasesTrue: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexAliasesTrueLabel', {
defaultMessage: 'This template contains index aliases',
}),
aliasesFalse: i18n.translate('xpack.idxMgmt.templateContentIndicator.indexAliasesFalseLabel', {
defaultMessage: 'This template does not contain index aliases',
}),
};

const mappingsText = mappings ? texts.mappingsTrue : texts.mappingsFalse;
const settingsText = settings ? texts.settingsTrue : texts.settingsFalse;
const aliasesText = aliases ? texts.aliasesTrue : texts.aliasesFalse;

return (
<>
<EuiToolTip content={texts.mappings}>
<EuiToolTip content={mappingsText}>
<>
<EuiBadge color={getColor(mappings)}>M</EuiBadge>
<EuiBadge color={getColor(mappings)} aria-label={mappingsText}>
M
</EuiBadge>
&nbsp;
</>
</EuiToolTip>
<EuiToolTip content={texts.settings}>
<EuiToolTip content={settingsText}>
<>
<EuiBadge color={getColor(settings)}>S</EuiBadge>
<EuiBadge color={getColor(settings)} aria-label={settingsText}>
S
</EuiBadge>
&nbsp;
</>
</EuiToolTip>
<EuiToolTip content={texts.aliases}>
<EuiBadge color={getColor(aliases)}>A</EuiBadge>
<EuiToolTip content={aliasesText}>
<EuiBadge color={getColor(aliases)} aria-label={aliasesText}>
A
</EuiBadge>
</EuiToolTip>
</>
);
Expand Down