Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Mgmt] Improve accessibility of templates table #199980

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 13, 2024

Summary

This improves the accessibility and understandability of the content column in the index templates page by:

  1. Improving the tooltip text to be explicit about whether something is present or not
  2. Adding an aria-label with the same content, as tooltips are not keyboard accessible

Checklist

Delete any items that are not applicable to this PR.

@sphilipse sphilipse requested a review from a team as a code owner November 13, 2024 11:18
@sphilipse sphilipse added the release_note:skip Skip the PR/issue when compiling release notes label Nov 13, 2024
@SoniaSanzV SoniaSanzV added the Feature:Index Management Index and index templates UI label Nov 13, 2024
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm :)

@sphilipse sphilipse enabled auto-merge (squash) November 13, 2024 13:44
@sphilipse sphilipse merged commit 20dd7f1 into elastic:main Nov 13, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.18, 8.x

https://github.com/elastic/kibana/actions/runs/11820626148

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 689.9KB 690.6KB +712.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2024
## Summary

This improves the accessibility and understandability of the content
column in the index templates page by:
1) Improving the tooltip text to be explicit about whether something is
present or not
2) Adding an aria-label with the same content, as tooltips are not
keyboard accessible

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))

(cherry picked from commit 20dd7f1)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2024
## Summary

This improves the accessibility and understandability of the content
column in the index templates page by:
1) Improving the tooltip text to be explicit about whether something is
present or not
2) Adding an aria-label with the same content, as tooltips are not
keyboard accessible

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))

(cherry picked from commit 20dd7f1)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16
8.18 The branch "8.18" does not exist
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 199980

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 13, 2024
#200030)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Index Mgmt] Improve accessibility of templates table
(#199980)](#199980)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T15:38:05Z","message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Index
Mgmt] Improve accessibility of templates
table","number":199980,"url":"https://github.com/elastic/kibana/pull/199980","mergeCommit":{"message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199980","number":199980,"mergeCommit":{"message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 13, 2024
…#200031)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Mgmt] Improve accessibility of templates table
(#199980)](#199980)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T15:38:05Z","message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Index
Mgmt] Improve accessibility of templates
table","number":199980,"url":"https://github.com/elastic/kibana/pull/199980","mergeCommit":{"message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199980","number":199980,"mergeCommit":{"message":"[Index
Mgmt] Improve accessibility of templates table (#199980)\n\n##
Summary\r\n\r\nThis improves the accessibility and understandability of
the content\r\ncolumn in the index templates page by:\r\n1) Improving
the tooltip text to be explicit about whether something is\r\npresent or
not\r\n2) Adding an aria-label with the same content, as tooltips are
not\r\nkeyboard accessible\r\n\r\n\r\n### Checklist\r\n\r\nDelete any
items that are not applicable to this PR.\r\n\r\n- [x] Any text added
follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] Any UI touched in this PR is usable by keyboard only (learn
more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"20dd7f1bbe61e6263476228d2225d68871849e25"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
## Summary

This improves the accessibility and understandability of the content
column in the index templates page by:
1) Improving the tooltip text to be explicit about whether something is
present or not
2) Adding an aria-label with the same content, as tooltips are not
keyboard accessible


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
## Summary

This improves the accessibility and understandability of the content
column in the index templates page by:
1) Improving the tooltip text to be explicit about whether something is
present or not
2) Adding an aria-label with the same content, as tooltips are not
keyboard accessible


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.16.1 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants