[Console] Avoid console url redirection #199966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Console
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7389[✅] test/functional/apps/console/config.ts: 100/100 tests passed. |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
mattkime
approved these changes
Nov 14, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @sabarasaba |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit ebd3f0d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Console] Avoid console url redirection (#199966)](#199966) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T12:56:11Z","message":"[Console] Avoid console url redirection (#199966)","sha":"ebd3f0d69e21b84f7f65e5f57ef0afcffc2f808a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console] Avoid console url redirection","number":199966,"url":"https://github.com/elastic/kibana/pull/199966","mergeCommit":{"message":"[Console] Avoid console url redirection (#199966)","sha":"ebd3f0d69e21b84f7f65e5f57ef0afcffc2f808a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199966","number":199966,"mergeCommit":{"message":"[Console] Avoid console url redirection (#199966)","sha":"ebd3f0d69e21b84f7f65e5f57ef0afcffc2f808a"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <[email protected]>
jesuswr
pushed a commit
to jesuswr/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196610
Fixes #196723
Summary
These two tests have failed in a non flaky way just few times the past month, I've ran them through the flaky test runner 100x and always pass. Spoke to someone from the QA team and they also don't think its a flaky nature. The only thing we think can be making a difference is preventing the hash redirection in kibana, so with this small PR I'm already adding the
/shellto the hash url to prevent that and we will keep an eye open to see if these come up again.