Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana Sustainable Architecture: Expose StatusResponse in core-status-common #200524

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Kibana Sustainable Architecture: Expose StatusResponse in core-status-common #200524

merged 3 commits into from
Nov 18, 2024

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Nov 18, 2024 •
edited by kibanamachine
Loading

Summary

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 18, 2024
@gsoldevila gsoldevila requested review from a team as code owners November 18, 2024 09:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-status-common 2 22 +20
@kbn/core-status-common-internal 20 - -20
total -0
Unknown metric groups

API count

id before after diff
@kbn/core-status-common 12 33 +21
@kbn/core-status-common-internal 21 - -21
total -0

History

@gsoldevila gsoldevila merged commit ab0375f into elastic:main Nov 18, 2024
49 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11893575743

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [EDR Workflows] Add Signer option to Mac trusted apps (#197821)
- [Console] Avoid console url redirection (#199966)
- [Infra] Change order of the errors shown on Infra pages (#200531)
- [SecuritySolution][Timeline] Remove timeline.isLoading (#198616)
- [[ES

Manual backport

To create the backport manually run:

node scripts/backport --pr 200524

Questions ?

Please refer to the Backport tool documentation

jesuswr pushed a commit to jesuswr/kibana that referenced this pull request Nov 18, 2024
@gsoldevila @kibanamachine @jesuswr
Kibana Sustainable Architecture: Expose StatusResponse in core-stat…
b5e0d05 
…us-common (elastic#200524)

## Summary

- Exposes the interfaces that define the format of the response of the
`/api/status` endpoint.
- Moves them from `@kbn/core-status-common-internal` to
`@kbn/core-status-common`.
- Removes the former package, as it no longer contains anything.
- Fixes some of the illegal dependencies uncovered by
elastic#199630.

---------

Co-authored-by: kibanamachine <[email protected]>
@gsoldevila gsoldevila mentioned this pull request Nov 19, 2024
Merged
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Nov 19, 2024
@gsoldevila
Kibana Sustainable Architecture: Expose StatusResponse in core-stat…
7a09c5a 
…us-common (elastic#200524)

## Summary

- Exposes the interfaces that define the format of the response of the
`/api/status` endpoint.
- Moves them from `@kbn/core-status-common-internal` to
`@kbn/core-status-common`.
- Removes the former package, as it no longer contains anything.
- Fixes some of the illegal dependencies uncovered by
elastic#199630.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ab0375f)

# Conflicts:
#	.github/CODEOWNERS
gsoldevila added a commit that referenced this pull request Nov 19, 2024
@gsoldevila
[8.x] Kibana Sustainable Architecture: Expose StatusResponse in cor…
af956f6 
…e-status-common (#200524) (#200685)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Kibana Sustainable Architecture: Expose `StatusResponse` in
core-status-common
(#200524)](#200524)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T13:34:54Z","message":"Kibana
Sustainable Architecture: Expose `StatusResponse` in core-status-common
(#200524)\n\n## Summary\n\n- Exposes the interfaces that define the
format of the response of the\n`/api/status` endpoint.\n- Moves them
from `@kbn/core-status-common-internal`
to\n`@kbn/core-status-common`.\n- Removes the former package, as it no
longer contains anything.\n- Fixes some of the illegal dependencies
uncovered
by\nhttps://github.com//pull/199630.\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ab0375f56fb9af1548631bf07e7c3fc4c06dc012","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":200524,"url":"https://github.com/elastic/kibana/pull/200524","mergeCommit":{"message":"Kibana
Sustainable Architecture: Expose `StatusResponse` in core-status-common
(#200524)\n\n## Summary\n\n- Exposes the interfaces that define the
format of the response of the\n`/api/status` endpoint.\n- Moves them
from `@kbn/core-status-common-internal`
to\n`@kbn/core-status-common`.\n- Removes the former package, as it no
longer contains anything.\n- Fixes some of the illegal dependencies
uncovered
by\nhttps://github.com//pull/199630.\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ab0375f56fb9af1548631bf07e7c3fc4c06dc012"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200524","number":200524,"mergeCommit":{"message":"Kibana
Sustainable Architecture: Expose `StatusResponse` in core-status-common
(#200524)\n\n## Summary\n\n- Exposes the interfaces that define the
format of the response of the\n`/api/status` endpoint.\n- Moves them
from `@kbn/core-status-common-internal`
to\n`@kbn/core-status-common`.\n- Removes the former package, as it no
longer contains anything.\n- Fixes some of the illegal dependencies
uncovered
by\nhttps://github.com//pull/199630.\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ab0375f56fb9af1548631bf07e7c3fc4c06dc012"}}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@gsoldevila @kibanamachine @CAWilson94
Kibana Sustainable Architecture: Expose StatusResponse in core-stat…
8dac33d 
…us-common (elastic#200524)

## Summary

- Exposes the interfaces that define the format of the response of the
`/api/status` endpoint.
- Moves them from `@kbn/core-status-common-internal` to
`@kbn/core-status-common`.
- Removes the former package, as it no longer contains anything.
- Fixes some of the illegal dependencies uncovered by
elastic#199630.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elena-shostak elena-shostak elena-shostak approved these changes

@rudolf rudolf rudolf approved these changes

@pzl pzl pzl approved these changes

@paul-tavares paul-tavares Awaiting requested review from paul-tavares paul-tavares was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gsoldevila @elasticmachine @kibanamachine @pzl @rudolf @elena-shostak