fix(slo): Use correct calendar period #199873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:fix
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
History
|
shahzad31
approved these changes
Nov 13, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 3cbdcc3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 3cbdcc3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 3cbdcc3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [fix(slo): Use correct calendar period (#199873)](#199873) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T18:39:45Z","message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): Use correct calendar period","number":199873,"url":"https://github.com/elastic/kibana/pull/199873","mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199873","number":199873,"mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [fix(slo): Use correct calendar period (#199873)](#199873) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T18:39:45Z","message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): Use correct calendar period","number":199873,"url":"https://github.com/elastic/kibana/pull/199873","mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199873","number":199873,"mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [fix(slo): Use correct calendar period (#199873)](#199873) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T18:39:45Z","message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"fix(slo): Use correct calendar period","number":199873,"url":"https://github.com/elastic/kibana/pull/199873","mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199873","number":199873,"mergeCommit":{"message":"fix(slo): Use correct calendar period (#199873)","sha":"3cbdcc3609269dcf109fe787359b2504203da229"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #199872
🎯 Summary
For a Occurrences and Calendar Aligned based SLO, we used to compute the summary looking at the previous period defined as now-7days (for a weekly calendar aligned) or now-1 month (for a monthly calendar aligned).
This is obviously wrong since we should compute the summary using only the data from the beginning of the current week or current month.
The fix only required to change the lower bound of the range filter to be either
now/wornow/Mwhich would translate to the beginning of the week or the month, for a calendar aligned SLO.Release note
Fix the summary calculation for a calendar aligned and occurrences based SLO