Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] added '\' escapes (#199185) #199373

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[8.x] added '\' escapes (#199185) #199373

merged 3 commits into from
Nov 21, 2024

Conversation

bryce-b
Copy link
Contributor

@bryce-b bryce-b commented Nov 7, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Bryce Buchanan <[email protected]>"}}]}] BACKPORT-->

@bryce-b
added '\' escapes (elastic#199185)
47279b0 
## Summary

This PR adds backslash escaping to previous code scan fixes.

(cherry picked from commit fb71142)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/public/pages/metrics/metrics_explorer/components/helpers/create_tsvb_link.ts
@bryce-b bryce-b enabled auto-merge (squash) November 7, 2024 19:42
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 7, 2024
@bryce-b bryce-b mentioned this pull request Nov 7, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 21, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: e57ace0
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199373-e57ace01e970

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +23.0B

History

@bryce-b bryce-b merged commit b09e1fd into elastic:8.x Nov 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryce-b @elasticmachine @legrego