added '\' escapes #199185
Merged
added '\' escapes #199185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-b
added
backport:version
|
Added targeted back-ports for 7.17 and 8.x. Hopefully I did that right. |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
approved these changes
Nov 6, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
added
the
release_note:skip
|
Starting backport for target branches: 7.17, 8.15 |
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
## Summary This PR adds backslash escaping to previous code scan fixes. (cherry picked from commit fb71142)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
# Backport This will backport the following commits from `main` to `7.17`: - [added '\' escapes (#199185)](#199185) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T19:02:41Z","message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.15.4","v7.17.26"],"title":"added '\\' escapes","number":199185,"url":"https://github.com/elastic/kibana/pull/199185","mergeCommit":{"message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","7.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199185","number":199185,"mergeCommit":{"message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2"}},{"branch":"8.15","label":"v8.15.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.26","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bryce Buchanan <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
## Summary This PR adds backslash escaping to previous code scan fixes.
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
bryce-b
added a commit
to bryce-b/kibana
that referenced
this pull request
Nov 7, 2024
## Summary This PR adds backslash escaping to previous code scan fixes. (cherry picked from commit fb71142) # Conflicts: # x-pack/plugins/observability_solution/infra/public/pages/metrics/metrics_explorer/components/helpers/create_tsvb_link.ts
bryce-b
added a commit
that referenced
this pull request
Nov 21, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [added '\' escapes (#199185)](#199185) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T19:02:41Z","message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.15.4","v7.17.26"],"number":199185,"url":"https://github.com/elastic/kibana/pull/199185","mergeCommit":{"message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199185","number":199185,"mergeCommit":{"message":"added '\\' escapes (#199185)\n\n## Summary\r\n\r\nThis PR adds backslash escaping to previous code scan fixes.","sha":"fb7114222b5bde5846fdda85a2ae0e94797600e2"}},{"branch":"8.15","label":"v8.15.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.26","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/199213","number":199213,"state":"MERGED","mergeCommit":{"sha":"83ca0265b5d9a0e11dd8092c7f9ab76c0df00d56","message":"[7.17] added '\\' escapes (#199185) (#199213)\n\n# Backport\n\nThis will backport the following commits from `main` to `7.17`:\n- [added '\\' escapes\n(#199185)](https://github.com/elastic/kibana/pull/199185)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Bryce\nBuchanan\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-06T19:02:41Z\",\"message\":\"added\n'\\\\' escapes (#199185)\\n\\n## Summary\\r\\n\\r\\nThis PR adds backslash\nescaping to previous code scan\nfixes.\",\"sha\":\"fb7114222b5bde5846fdda85a2ae0e94797600e2\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"backport:version\",\"v8.15.4\",\"v7.17.26\"],\"title\":\"added\n'\\\\'\nescapes\",\"number\":199185,\"url\":\"https://github.com/elastic/kibana/pull/199185\",\"mergeCommit\":{\"message\":\"added\n'\\\\' escapes (#199185)\\n\\n## Summary\\r\\n\\r\\nThis PR adds backslash\nescaping to previous code scan\nfixes.\",\"sha\":\"fb7114222b5bde5846fdda85a2ae0e94797600e2\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.15\",\"7.17\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/199185\",\"number\":199185,\"mergeCommit\":{\"message\":\"added\n'\\\\' escapes (#199185)\\n\\n## Summary\\r\\n\\r\\nThis PR adds backslash\nescaping to previous code scan\nfixes.\",\"sha\":\"fb7114222b5bde5846fdda85a2ae0e94797600e2\"}},{\"branch\":\"8.15\",\"label\":\"v8.15.4\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"7.17\",\"label\":\"v7.17.26\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Bryce Buchanan <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Larry Gregory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds backslash escaping to previous code scan fixes.