Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: Remove placeholders from default config #199135

Closed
wants to merge 4 commits into from

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 6, 2024

This PR rolls back a part of #195735 because it breaks the auto-detect onboarding flow: #199117

It removes the placeholders that break the config file syntax - we can add them back once this problem is resolved.

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Nov 6, 2024
@flash1293 flash1293 requested a review from a team as a code owner November 6, 2024 13:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / useMonitorStatusData handles resize events and requests based on new data
  • [job] [logs] Jest Tests #7 / When using the ResponseActionFileDownloadLink component should show download button if file is available

Metrics [docs]

✅ unchanged

History

@flash1293 flash1293 closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants