[Fleet] Improve input template API yaml comments #199168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
flash1293
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/oblt-deploy |
I don't think the original PR made it into 8.16 |
|
@flash1293 it seems it is in 8.16.0 the code is present in the 8.16 branch |
|
@nchaulet Then we should definitely backport to 8.16 The last BC will be cut tomorrow, let's make sure to get it in today |
flash1293
approved these changes
Nov 6, 2024
kpollich
approved these changes
Nov 6, 2024
|
@elasticmachine merge upstream |
kpollich
approved these changes
Nov 6, 2024
⏳ Build in-progress
History
cc @nchaulet |
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit 8041372)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit 8041372)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…99238) # Backport This will backport the following commits from `main` to `8.16`: - [[Fleet] Improve input template API yaml comments (#199168)](#199168) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T22:01:19Z","message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0","v8.17.0"],"title":"[Fleet] Improve input template API yaml comments","number":199168,"url":"https://github.com/elastic/kibana/pull/199168","mergeCommit":{"message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199168","number":199168,"mergeCommit":{"message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Joe Reuter <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…9239) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Improve input template API yaml comments (#199168)](#199168) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T22:01:19Z","message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0","v8.17.0"],"title":"[Fleet] Improve input template API yaml comments","number":199168,"url":"https://github.com/elastic/kibana/pull/199168","mergeCommit":{"message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199168","number":199168,"mergeCommit":{"message":"[Fleet] Improve input template API yaml comments (#199168)","sha":"8041372868f732530d7fecf1c44fad1f61b631fc"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Nicolas Chaulet <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/elastic/observability-dev/issues/3200
Replace #199135
Improve the yaml we generate for input template, previously we introduced placeholder variables to include variables without default in the generated YAML. To make that yaml valid for agents we will now comment the lines where we introduced placeholder.
For example for system and redis integration the template looks like this now:
Do we want to backport this to 8.16.0 ?