Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bfetch #199066

Closed
wants to merge 48 commits into from
Closed

Remove bfetch #199066

wants to merge 48 commits into from

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Nov 5, 2024

Summary

Relies on #196962 and #197150.
Resolves #186139.

Removes the bfetch plugin & updates documentation accordingly.

Checklist

Risk Matrix

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana release_note:breaking backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 5, 2024
@lukasolson lukasolson self-assigned this Nov 5, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 5, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Copy link
Contributor

github-actions bot commented Nov 5, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 13, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 136 134 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.5MB 3.5MB -390.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 137 135 -2

ESLint disabled line counts

id before after diff
@kbn/test-suites-src 59 57 -2

Total ESLint disabled count

id before after diff
@kbn/test-suites-src 65 63 -2

History

cc @lukasolson

lukasolson added a commit that referenced this pull request Dec 16, 2024
## Summary

Part of #186139.

First step of breaking up #199066
into smaller pieces.

Removes the bfetch explorer example plugin.
@lukasolson
Copy link
Member Author

Closing in favor of #204285

@lukasolson lukasolson closed this Dec 18, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## Summary

Part of elastic#186139.

First step of breaking up elastic#199066
into smaller pieces.

Removes the bfetch explorer example plugin.
lukasolson added a commit that referenced this pull request Dec 19, 2024
## Summary

Part of #186139.

Relies on #204284.

Second step of breaking up #199066
into smaller pieces.

Removes the bfetch and bfetch-error plugins.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Search Querying infrastructure in Kibana release_note:breaking Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data.search] Remove bfetch/bsearch
4 participants