Skip to content

Commit

Permalink
Remove bfetch plugin (#204285)
Browse files Browse the repository at this point in the history
## Summary

Part of #186139.

Relies on #204284.

Second step of breaking up #199066
into smaller pieces.

Removes the bfetch and bfetch-error plugins.

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
lukasolson and kibanamachine authored Dec 19, 2024
1 parent d7280a1 commit 9ad31d0
Show file tree
Hide file tree
Showing 79 changed files with 90 additions and 3,463 deletions.
4 changes: 0 additions & 4 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ packages/kbn-babel-preset @elastic/kibana-operations
packages/kbn-babel-register @elastic/kibana-operations
packages/kbn-babel-transform @elastic/kibana-operations
packages/kbn-bazel-runner @elastic/kibana-operations
packages/kbn-bfetch-error @elastic/appex-sharedux
packages/kbn-calculate-auto @elastic/obs-ux-management-team
packages/kbn-calculate-width-from-char-count @elastic/kibana-visualizations
packages/kbn-capture-oas-snapshot-cli @elastic/kibana-core
Expand Down Expand Up @@ -619,7 +618,6 @@ src/platform/plugins/shared/esql @elastic/kibana-esql
src/platform/plugins/shared/esql_datagrid @elastic/kibana-esql
src/platform/plugins/shared/management @elastic/kibana-management
src/plugins/advanced_settings @elastic/appex-sharedux @elastic/kibana-management
src/plugins/bfetch @elastic/appex-sharedux
src/plugins/chart_expressions/common @elastic/kibana-visualizations
src/plugins/chart_expressions/expression_gauge @elastic/kibana-visualizations
src/plugins/chart_expressions/expression_heatmap @elastic/kibana-visualizations
Expand Down Expand Up @@ -2911,7 +2909,6 @@ src/platform/packages/shared/kbn-analytics @elastic/kibana-core
src/platform/packages/shared/kbn-apm-data-view @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-apm-utils @elastic/obs-ux-infra_services-team
src/platform/packages/shared/kbn-avc-banner @elastic/security-defend-workflows
src/platform/packages/shared/kbn-bfetch-error @elastic/appex-sharedux
src/platform/packages/shared/kbn-calculate-width-from-char-count @elastic/kibana-visualizations
src/platform/packages/shared/kbn-cases-components @elastic/response-ops
src/platform/packages/shared/kbn-cbor @elastic/kibana-operations
Expand Down Expand Up @@ -3091,7 +3088,6 @@ src/platform/plugins/private/vis_types/vega @elastic/kibana-visualizations
src/platform/plugins/private/vis_types/vislib @elastic/kibana-visualizations
src/platform/plugins/private/vis_types/xy @elastic/kibana-visualizations
src/platform/plugins/shared/ai_assistant_management/selection @elastic/obs-ai-assistant
src/platform/plugins/shared/bfetch @elastic/appex-sharedux
src/platform/plugins/shared/chart_expressions/expression_gauge @elastic/kibana-visualizations
src/platform/plugins/shared/chart_expressions/expression_heatmap @elastic/kibana-visualizations
src/platform/plugins/shared/chart_expressions/expression_legacy_metric @elastic/kibana-visualizations
Expand Down
2 changes: 0 additions & 2 deletions .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
"apmOss": "src/plugins/apm_oss",
"autocomplete": "x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src",
"avcBanner": "src/platform/packages/shared/kbn-avc-banner/src",
"bfetch": "src/plugins/bfetch",
"bfetchError": "packages/kbn-bfetch-error",
"cases": ["packages/kbn-cases-components"],
"cellActions": "src/platform/packages/shared/kbn-cell-actions",
"charts": "src/plugins/charts",
Expand Down
4 changes: 0 additions & 4 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ as uiSettings within the code.
|The aiAssistantManagementSelection plugin manages the Ai Assistant management section.
|{kib-repo}blob/{branch}/src/plugins/bfetch/README.md[bfetch]
|bfetch allows to batch HTTP requests and streams responses back.
|{kib-repo}blob/{branch}/src/plugins/charts/README.md[charts]
|The Charts plugin is a way to create easier integration of shared colors, themes, types and other utilities across all Kibana charts and visualizations.
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@
"@kbn/audit-log-plugin": "link:x-pack/test/security_api_integration/plugins/audit_log",
"@kbn/avc-banner": "link:src/platform/packages/shared/kbn-avc-banner",
"@kbn/banners-plugin": "link:x-pack/plugins/banners",
"@kbn/bfetch-error": "link:packages/kbn-bfetch-error",
"@kbn/bfetch-plugin": "link:src/plugins/bfetch",
"@kbn/calculate-auto": "link:packages/kbn-calculate-auto",
"@kbn/calculate-width-from-char-count": "link:packages/kbn-calculate-width-from-char-count",
"@kbn/canvas-plugin": "link:x-pack/plugins/canvas",
Expand Down
35 changes: 0 additions & 35 deletions packages/kbn-bfetch-error/BUILD.bazel

This file was deleted.

3 changes: 0 additions & 3 deletions packages/kbn-bfetch-error/README.md

This file was deleted.

10 changes: 0 additions & 10 deletions packages/kbn-bfetch-error/index.ts

This file was deleted.

14 changes: 0 additions & 14 deletions packages/kbn-bfetch-error/jest.config.js

This file was deleted.

9 changes: 0 additions & 9 deletions packages/kbn-bfetch-error/kibana.jsonc

This file was deleted.

6 changes: 0 additions & 6 deletions packages/kbn-bfetch-error/package.json

This file was deleted.

38 changes: 0 additions & 38 deletions packages/kbn-bfetch-error/src/bfetch_error.ts

This file was deleted.

21 changes: 0 additions & 21 deletions packages/kbn-bfetch-error/tsconfig.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ pageLoadAssetSize:
apm: 64385
assetInventory: 18478
banners: 17946
bfetch: 22837
canvas: 29355
cases: 180037
charts: 55000
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-search-errors/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ SRCS = glob(
)

BUNDLER_DEPS = [
"//packages/kbn-bfetch-error",
"//packages/kbn-i18n",
"@npm//@elastic/elasticsearch",
"@npm//@elastic/eui",
Expand Down
3 changes: 1 addition & 2 deletions packages/kbn-search-errors/src/render_search_error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import { i18n } from '@kbn/i18n';
import { ReactNode } from 'react';
import { BfetchRequestError } from '@kbn/bfetch-error';
import { EsError } from './es_error';

export function renderSearchError(
Expand All @@ -25,7 +24,7 @@ export function renderSearchError(
};
}

if (error.constructor.name === 'HttpFetchError' || error instanceof BfetchRequestError) {
if (error.constructor.name === 'HttpFetchError') {
const defaultMsg = i18n.translate('searchErrors.errors.fetchError', {
defaultMessage: 'Check your network connection and try again.',
});
Expand Down
1 change: 0 additions & 1 deletion packages/kbn-search-errors/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"@kbn/core",
"@kbn/kibana-utils-plugin",
"@kbn/data-views-plugin",
"@kbn/bfetch-error",
"@kbn/search-types",
]
}
56 changes: 0 additions & 56 deletions src/plugins/bfetch/README.md

This file was deleted.

27 changes: 0 additions & 27 deletions src/plugins/bfetch/common/batch.ts

This file was deleted.

65 changes: 0 additions & 65 deletions src/plugins/bfetch/common/buffer/create_batched_function.test.ts

This file was deleted.

Loading

0 comments on commit 9ad31d0

Please sign in to comment.