[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists #199017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-dr
added
test
Team:QA
|
Pinging @elastic/appex-qa (Team:QA) |
|
Starting backport for target branches: 8.16, 8.18, 8.x |
💚 Build Succeeded
Metrics [docs]
cc @bhavyarm |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…elpifExists (elastic#199017) ## Summary With the change from the ace console to monaco console, the UI has changed and the methods as well. We're now using `skipTourIfExists` instead of `closeHelpIfExists`. (cherry picked from commit 2a9b42a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…elpifExists (elastic#199017) ## Summary With the change from the ace console to monaco console, the UI has changed and the methods as well. We're now using `skipTourIfExists` instead of `closeHelpIfExists`. (cherry picked from commit 2a9b42a)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
… closeHelpifExists (#199017) (#199034) # Backport This will backport the following commits from `main` to `8.16`: - [[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)](#199017) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marius Dragomir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T17:51:39Z","message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:QA","release_note:skip","test-stack-integration","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists","number":199017,"url":"https://github.com/elastic/kibana/pull/199017","mergeCommit":{"message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199017","number":199017,"mergeCommit":{"message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marius Dragomir <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…closeHelpifExists (#199017) (#199035) # Backport This will backport the following commits from `main` to `8.x`: - [[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)](#199017) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marius Dragomir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T17:51:39Z","message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:QA","release_note:skip","test-stack-integration","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists","number":199017,"url":"https://github.com/elastic/kibana/pull/199017","mergeCommit":{"message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199017","number":199017,"mergeCommit":{"message":"[QA]Change to skipTourIfExists in console CCS tests instead of closeHelpifExists (#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to monaco console, the UI has\r\nchanged and the methods as well. We're now using `skipTourIfExists`\r\ninstead of `closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marius Dragomir <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…elpifExists (elastic#199017) ## Summary With the change from the ace console to monaco console, the UI has changed and the methods as well. We're now using `skipTourIfExists` instead of `closeHelpIfExists`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the change from the ace console to monaco console, the UI has changed and the methods as well. We're now using
skipTourIfExistsinstead ofcloseHelpIfExists.