Skip to content

Commit

Permalink
[8.x] [QA]Change to skipTourIfExists in console CCS tests instead of …
Browse files Browse the repository at this point in the history
…closeHelpifExists (#199017) (#199035)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[QA]Change to skipTourIfExists in console CCS tests instead of
closeHelpifExists
(#199017)](#199017)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marius
Dragomir","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T17:51:39Z","message":"[QA]Change
to skipTourIfExists in console CCS tests instead of closeHelpifExists
(#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to
monaco console, the UI has\r\nchanged and the methods as well. We're now
using `skipTourIfExists`\r\ninstead of
`closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:QA","release_note:skip","test-stack-integration","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[QA]Change
to skipTourIfExists in console CCS tests instead of
closeHelpifExists","number":199017,"url":"https://github.com/elastic/kibana/pull/199017","mergeCommit":{"message":"[QA]Change
to skipTourIfExists in console CCS tests instead of closeHelpifExists
(#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to
monaco console, the UI has\r\nchanged and the methods as well. We're now
using `skipTourIfExists`\r\ninstead of
`closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199017","number":199017,"mergeCommit":{"message":"[QA]Change
to skipTourIfExists in console CCS tests instead of closeHelpifExists
(#199017)\n\n## Summary\r\n\r\nWith the change from the ace console to
monaco console, the UI has\r\nchanged and the methods as well. We're now
using `skipTourIfExists`\r\ninstead of
`closeHelpIfExists`.","sha":"2a9b42a0dbcf6094854194e6e8775e0d4e7a5a18"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marius Dragomir <[email protected]>
  • Loading branch information
kibanamachine and marius-dr authored Nov 5, 2024
1 parent 0065987 commit 4fb9954
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.common.navigateToApp('console');
await PageObjects.common.dismissBanner();
await retry.try(async () => {
await PageObjects.console.closeHelpIfExists();
await PageObjects.console.skipTourIfExists();
});
});

Expand Down

0 comments on commit 4fb9954

Please sign in to comment.