Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][NewRuleForm] Update functional tests to use new rule form for stack management #198915

Merged
merged 15 commits into from
Nov 28, 2024
Merged

[ResponseOps][NewRuleForm] Update functional tests to use new rule form for stack management #198915

merged 15 commits into from
Nov 28, 2024

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Nov 5, 2024 •
edited by kibanamachine
Loading

Summary

Meta issue #196235

This PR updates existing e2e tests to use the new rule form instead of old rule flyout for stack management > rules

Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

Checklist

@js-jankisalvi js-jankisalvi self-assigned this Nov 5, 2024
@js-jankisalvi js-jankisalvi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 Feature:Alerting/RulesManagement Issues related to the Rules Management UX backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 26, 2024
@js-jankisalvi js-jankisalvi marked this pull request as ready for review November 26, 2024 14:36
@js-jankisalvi js-jankisalvi requested review from a team as code owners November 26, 2024 14:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7488

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 0/25 tests passed.
[❌] x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts: 24/25 tests passed.

see run history

davismcphee
davismcphee approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes in search_source_alert.ts LGTM 👍

peteharverson
peteharverson approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ML tests LGTM

darnautov
darnautov approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7527

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 0/25 tests passed.
[❌] x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts: 24/25 tests passed.

see run history

@js-jankisalvi js-jankisalvi enabled auto-merge (squash) November 28, 2024 12:17
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7530

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 0/25 tests passed.
[❌] x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts: 24/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 28, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #80 / Actions and Triggers app Rules list rules list should filter alerts by the rule status
  • [job] [logs] FTR Configs #80 / Actions and Triggers app Rules list rules list should filter alerts by the rule status
  • [job] [logs] Jest Tests #15 / PackagePolicyDeleteProvider Should show delete integrations action and cancel modal

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +175.0B

History

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit a896987 into elastic:main Nov 28, 2024
8 checks passed
@js-jankisalvi js-jankisalvi deleted the functional-tests-using-new-rule-form branch November 28, 2024 16:50
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12072885110

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
@js-jankisalvi
[ResponseOps][NewRuleForm] Update functional tests to use new rule fo…
7b21533 
…rm for stack management (elastic#198915)

## Summary

Meta issue elastic#196235

This PR updates existing e2e tests to use the new rule form instead of
old rule flyout for `stack management > rules`

### Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a896987)
@kibanamachine kibanamachine mentioned this pull request Nov 28, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2024
@kibanamachine @js-jankisalvi
[8.x] [ResponseOps][NewRuleForm] Update functional tests to use new r…
4581688 
…ule form for stack management (#198915) (#202212)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][NewRuleForm] Update functional tests to use new rule
form for stack management
(#198915)](#198915)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T16:50:07Z","message":"[ResponseOps][NewRuleForm]
Update functional tests to use new rule form for stack management
(#198915)\n\n## Summary\r\n\r\nMeta issue
https://github.com/elastic/kibana/issues/196235\r\n\r\nThis PR updates
existing e2e tests to use the new rule form instead of\r\nold rule
flyout for `stack management > rules`\r\n\r\n### Flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a89698712b77fd6d4745e82123dccb2758b42e63","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesManagement","backport:prev-minor","v8.18.0"],"title":"[ResponseOps][NewRuleForm]
Update functional tests to use new rule form for stack
management","number":198915,"url":"https://github.com/elastic/kibana/pull/198915","mergeCommit":{"message":"[ResponseOps][NewRuleForm]
Update functional tests to use new rule form for stack management
(#198915)\n\n## Summary\r\n\r\nMeta issue
https://github.com/elastic/kibana/issues/196235\r\n\r\nThis PR updates
existing e2e tests to use the new rule form instead of\r\nold rule
flyout for `stack management > rules`\r\n\r\n### Flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a89698712b77fd6d4745e82123dccb2758b42e63"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198915","number":198915,"mergeCommit":{"message":"[ResponseOps][NewRuleForm]
Update functional tests to use new rule form for stack management
(#198915)\n\n## Summary\r\n\r\nMeta issue
https://github.com/elastic/kibana/issues/196235\r\n\r\nThis PR updates
existing e2e tests to use the new rule form instead of\r\nold rule
flyout for `stack management > rules`\r\n\r\n### Flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a89698712b77fd6d4745e82123dccb2758b42e63"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <[email protected]>
@cnasikas cnasikas mentioned this pull request Dec 9, 2024
Open
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@js-jankisalvi @CAWilson94
[ResponseOps][NewRuleForm] Update functional tests to use new rule fo…
0a3e85a 
…rm for stack management (elastic#198915)

## Summary

Meta issue elastic#196235

This PR updates existing e2e tests to use the new rule form instead of
old rule flyout for `stack management > rules`

### Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@jcger jcger jcger approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

@adcoelho adcoelho adcoelho approved these changes

@Zacqary Zacqary Awaiting requested review from Zacqary

Assignees

@js-jankisalvi js-jankisalvi

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@js-jankisalvi @elasticmachine @kibanamachine @adcoelho @darnautov @peteharverson @jcger @davismcphee