Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] New rule form leftovers #196235

Open
5 of 19 tasks
cnasikas opened this issue Oct 15, 2024 · 2 comments
Open
5 of 19 tasks

[ResponseOps][Rules] New rule form leftovers #196235

cnasikas opened this issue Oct 15, 2024 · 2 comments
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Meta Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 15, 2024 •
edited
Loading

In #194655 we enabled the new rule form for the stack management page. This issue tracks leftover work.

Tasks
Preview Give feedback
  18. [ResponseOps][Rules] Deprecate the RuleFormV2 feature flag #196493
    Feature:Alerting/RulesFramework Team:ResponseOps bug
    adcoelho
  19. [ResponseOps][Rules] Remove the RuleFormV2 from plugins that do not need it #196704
    Feature:Alerting/RulesManagement Team:ResponseOps technical debt
@cnasikas cnasikas added Feature:Alerting/RulesManagement Issues related to the Rules Management UX Meta Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@js-jankisalvi js-jankisalvi mentioned this issue Oct 28, 2024
Merged
1 task
@js-jankisalvi
Copy link
Contributor

Verify the following and fix if it exists: The Hive connector behaves as it is (without any error) when licence is Basic, even though required licence for it is Platinum.

Couldn't reproduce the issue, able to see correct message

Image

This was referenced Nov 1, 2024
Closed
Closed
js-jankisalvi added a commit that referenced this issue Nov 4, 2024
@js-jankisalvi
[ResponseOps][New Rule Form] Fix new rule form issues with basic lice…
962082e 
…nse (#198036)

## Summary

Fixes below issues from new rule form leftovers
#196235

<details><summary>On basic license, if I hover on unsupported
connectors, a tooltip explains the reasoning. This is not happening for
rule types. We should do the same for the rule types</summary>

![Screenshot 2024-10-28 at 15 44
26](https://github.com/user-attachments/assets/522a9a54-fa41-48e2-a749-58a465eb2543)
</details> 

<details><summary>On basic license, I can edit a rule that is not
available on the basic. This leads to a bunch of errors in edit mode.
The same is happening on main. We should prevent accessing this kind of
rule types.</summary>

![Screenshot 2024-10-28 at 15 44
57](https://github.com/user-attachments/assets/9a016ef2-aaf2-4d3f-8161-70bcb89f3334)
</details> 

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 4, 2024
@js-jankisalvi
[ResponseOps][New Rule Form] Fix new rule form issues with basic lice…
6b7df32 
…nse (elastic#198036)

## Summary

Fixes below issues from new rule form leftovers
elastic#196235

<details><summary>On basic license, if I hover on unsupported
connectors, a tooltip explains the reasoning. This is not happening for
rule types. We should do the same for the rule types</summary>

![Screenshot 2024-10-28 at 15 44
26](https://github.com/user-attachments/assets/522a9a54-fa41-48e2-a749-58a465eb2543)
</details>

<details><summary>On basic license, I can edit a rule that is not
available on the basic. This leads to a bunch of errors in edit mode.
The same is happening on main. We should prevent accessing this kind of
rule types.</summary>

![Screenshot 2024-10-28 at 15 44
57](https://github.com/user-attachments/assets/9a016ef2-aaf2-4d3f-8161-70bcb89f3334)
</details>

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 962082e)
kibanamachine added a commit that referenced this issue Nov 4, 2024
@kibanamachine @js-jankisalvi
[8.x] [ResponseOps][New Rule Form] Fix new rule form issues with basi…
2f470d3 
…c license (#198036) (#198842)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][New Rule Form] Fix new rule form issues with basic
license (#198036)](#198036)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T19:13:33Z","message":"[ResponseOps][New
Rule Form] Fix new rule form issues with basic license (#198036)\n\n##
Summary\r\n\r\nFixes below issues from new rule form
leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On
basic license, if I hover on unsupported\r\nconnectors, a tooltip
explains the reasoning. This is not happening for\r\nrule types. We
should do the same for the rule types</summary>\r\n\r\n![Screenshot
2024-10-28 at 15
44\r\n26](https://github.com/user-attachments/assets/522a9a54-fa41-48e2-a749-58a465eb2543)\r\n</details>
\r\n\r\n<details><summary>On basic license, I can edit a rule that is
not\r\navailable on the basic. This leads to a bunch of errors in edit
mode.\r\nThe same is happening on main. We should prevent accessing this
kind of\r\nrule types.</summary>\r\n\r\n![Screenshot 2024-10-28 at 15
44\r\n57](https://github.com/user-attachments/assets/9a016ef2-aaf2-4d3f-8161-70bcb89f3334)\r\n</details>
\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[ResponseOps][New
Rule Form] Fix new rule form issues with basic
license","number":198036,"url":"https://github.com/elastic/kibana/pull/198036","mergeCommit":{"message":"[ResponseOps][New
Rule Form] Fix new rule form issues with basic license (#198036)\n\n##
Summary\r\n\r\nFixes below issues from new rule form
leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On
basic license, if I hover on unsupported\r\nconnectors, a tooltip
explains the reasoning. This is not happening for\r\nrule types. We
should do the same for the rule types</summary>\r\n\r\n![Screenshot
2024-10-28 at 15
44\r\n26](https://github.com/user-attachments/assets/522a9a54-fa41-48e2-a749-58a465eb2543)\r\n</details>
\r\n\r\n<details><summary>On basic license, I can edit a rule that is
not\r\navailable on the basic. This leads to a bunch of errors in edit
mode.\r\nThe same is happening on main. We should prevent accessing this
kind of\r\nrule types.</summary>\r\n\r\n![Screenshot 2024-10-28 at 15
44\r\n57](https://github.com/user-attachments/assets/9a016ef2-aaf2-4d3f-8161-70bcb89f3334)\r\n</details>
\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198036","number":198036,"mergeCommit":{"message":"[ResponseOps][New
Rule Form] Fix new rule form issues with basic license (#198036)\n\n##
Summary\r\n\r\nFixes below issues from new rule form
leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On
basic license, if I hover on unsupported\r\nconnectors, a tooltip
explains the reasoning. This is not happening for\r\nrule types. We
should do the same for the rule types</summary>\r\n\r\n![Screenshot
2024-10-28 at 15
44\r\n26](https://github.com/user-attachments/assets/522a9a54-fa41-48e2-a749-58a465eb2543)\r\n</details>
\r\n\r\n<details><summary>On basic license, I can edit a rule that is
not\r\navailable on the basic. This leads to a bunch of errors in edit
mode.\r\nThe same is happening on main. We should prevent accessing this
kind of\r\nrule types.</summary>\r\n\r\n![Screenshot 2024-10-28 at 15
44\r\n57](https://github.com/user-attachments/assets/9a016ef2-aaf2-4d3f-8161-70bcb89f3334)\r\n</details>
\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <[email protected]>
@js-jankisalvi js-jankisalvi mentioned this issue Nov 26, 2024
Merged
1 task
js-jankisalvi added a commit that referenced this issue Nov 28, 2024
@js-jankisalvi
[ResponseOps][NewRuleForm] Update functional tests to use new rule fo…
a896987 
…rm for stack management (#198915)

## Summary

Meta issue #196235

This PR updates existing e2e tests to use the new rule form instead of
old rule flyout for `stack management > rules`

### Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 28, 2024
@js-jankisalvi
[ResponseOps][NewRuleForm] Update functional tests to use new rule fo…
7b21533 
…rm for stack management (elastic#198915)

## Summary

Meta issue elastic#196235

This PR updates existing e2e tests to use the new rule form instead of
old rule flyout for `stack management > rules`

### Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a896987)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@js-jankisalvi @CAWilson94
[ResponseOps][NewRuleForm] Update functional tests to use new rule fo…
0a3e85a 
…rm for stack management (elastic#198915)

## Summary

Meta issue elastic#196235

This PR updates existing e2e tests to use the new rule form instead of
old rule flyout for `stack management > rules`

### Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7488
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7530

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Meta Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @elasticmachine @js-jankisalvi