Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard (#197456) #198804

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…active API keys, via keyboard (elastic#197456)

Closes: elastic#195209

This PR is based on the following comment:

> @cee-chen / @bhavyarm, could you please validate this issue? I'm not
sure if the badge should be keyboard accessible. On the other hand, I
think it might make sense to move active API keys inside the badge.
However, this is more of a design question rather than an a11y one.

_Originally posted by @alexwizp in
[elastic#195209](elastic#195209 (comment)

This PR move text inside badge to address a11y concerns.

## Screen:

<img width="734" alt="image"
src="https://github.com/user-attachments/assets/66b2d4f5-75ee-4a1a-b286-03cd346d9aeb">

(cherry picked from commit 0a1ec8f)
@kibanamachine kibanamachine merged commit 094c46d into elastic:8.x Nov 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants