fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard #197456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…active API keys, via keyboard Closes: elastic#195209
|
/ci |
alexwizp
added
release_note:skip
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Rather than changing the design, could you add a |
|
@elastic/search-kibana please have a look. It looks like we have 2 options, which one do you like more? |
sphilipse
approved these changes
Nov 4, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
…active API keys, via keyboard (elastic#197456) Closes: elastic#195209 This PR is based on the following comment: > @cee-chen / @bhavyarm, could you please validate this issue? I'm not sure if the badge should be keyboard accessible. On the other hand, I think it might make sense to move active API keys inside the badge. However, this is more of a design question rather than an a11y one. _Originally posted by @alexwizp in [elastic#195209](elastic#195209 (comment) This PR move text inside badge to address a11y concerns. ## Screen: <img width="734" alt="image" src="https://github.com/user-attachments/assets/66b2d4f5-75ee-4a1a-b286-03cd346d9aeb"> (cherry picked from commit 0a1ec8f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
…er of active API keys, via keyboard (#197456) (#198804) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard (#197456)](#197456) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:47:33Z","message":"fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard (#197456)\n\nCloses: #195209\r\n\r\nThis PR is based on the following comment: \r\n\r\n> @cee-chen / @bhavyarm, could you please validate this issue? I'm not\r\nsure if the badge should be keyboard accessible. On the other hand, I\r\nthink it might make sense to move active API keys inside the badge.\r\nHowever, this is more of a design question rather than an a11y one.\r\n\r\n_Originally posted by @alexwizp in\r\n[#195209](https://github.com/elastic/kibana/issues/195209#issuecomment-2429091670)_\r\n\r\nThis PR move text inside badge to address a11y concerns.\r\n\r\n## Screen: \r\n\r\n<img width=\"734\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66b2d4f5-75ee-4a1a-b286-03cd346d9aeb\">","sha":"0a1ec8f846cb0c78cfe3ddd0f2c1b4ccd1b3365b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard","number":197456,"url":"https://github.com/elastic/kibana/pull/197456","mergeCommit":{"message":"fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard (#197456)\n\nCloses: #195209\r\n\r\nThis PR is based on the following comment: \r\n\r\n> @cee-chen / @bhavyarm, could you please validate this issue? I'm not\r\nsure if the badge should be keyboard accessible. On the other hand, I\r\nthink it might make sense to move active API keys inside the badge.\r\nHowever, this is more of a design question rather than an a11y one.\r\n\r\n_Originally posted by @alexwizp in\r\n[#195209](https://github.com/elastic/kibana/issues/195209#issuecomment-2429091670)_\r\n\r\nThis PR move text inside badge to address a11y concerns.\r\n\r\n## Screen: \r\n\r\n<img width=\"734\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66b2d4f5-75ee-4a1a-b286-03cd346d9aeb\">","sha":"0a1ec8f846cb0c78cfe3ddd0f2c1b4ccd1b3365b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197456","number":197456,"mergeCommit":{"message":"fix: [Stateful: Home page] Not accessible element, showing number of active API keys, via keyboard (#197456)\n\nCloses: #195209\r\n\r\nThis PR is based on the following comment: \r\n\r\n> @cee-chen / @bhavyarm, could you please validate this issue? I'm not\r\nsure if the badge should be keyboard accessible. On the other hand, I\r\nthink it might make sense to move active API keys inside the badge.\r\nHowever, this is more of a design question rather than an a11y one.\r\n\r\n_Originally posted by @alexwizp in\r\n[#195209](https://github.com/elastic/kibana/issues/195209#issuecomment-2429091670)_\r\n\r\nThis PR move text inside badge to address a11y concerns.\r\n\r\n## Screen: \r\n\r\n<img width=\"734\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/66b2d4f5-75ee-4a1a-b286-03cd346d9aeb\">","sha":"0a1ec8f846cb0c78cfe3ddd0f2c1b4ccd1b3365b"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Nov 6, 2024
…I keys.` text. (#199096) This PR fixes a small typo in #197456. No need to add `.` for text placed in `EuiBadge` ## Screen <img width="461" alt="image" src="https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
…I keys.` text. (elastic#199096) This PR fixes a small typo in elastic#197456. No need to add `.` for text placed in `EuiBadge` ## Screen <img width="461" alt="image" src="https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd"> (cherry picked from commit 1b9079f)
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
…60;{number} active API keys.` text. (#199096) (#199179)
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Search: Home page] Remove the extra `.` from the
`{number} active API keys.` text.
(#199096)](#199096)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:38:42Z","message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text.","number":199096,"url":"https://github.com/elastic/kibana/pull/199096","mergeCommit":{"message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199096","number":199096,"mergeCommit":{"message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767"}}]}]
BACKPORT-->
Co-authored-by: Alexey Antonov <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…I keys.` text. (elastic#199096) This PR fixes a small typo in elastic#197456. No need to add `.` for text placed in `EuiBadge` ## Screen <img width="461" alt="image" src="https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #195209
This PR is based on the following comment:
Originally posted by @alexwizp in #195209
This PR move text inside badge to address a11y concerns.
Screen: