Fix tablelistview test due to timezone switch #198759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
eokoneyo
approved these changes
Nov 4, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary Fix elastic#198744 Test was subtracting 7 days, but there is 1 hour less now, so the test setup is incorrect. Fixing it by using moment to handle time switch edge case (cherry picked from commit a88833c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary Fix elastic#198744 Test was subtracting 7 days, but there is 1 hour less now, so the test setup is incorrect. Fixing it by using moment to handle time switch edge case (cherry picked from commit a88833c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary Fix elastic#198744 Test was subtracting 7 days, but there is 1 hour less now, so the test setup is incorrect. Fixing it by using moment to handle time switch edge case (cherry picked from commit a88833c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [Fix tablelistview test due to timezone switch (#198759)](#198759) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T11:39:05Z","message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"Fix tablelistview test due to timezone switch","number":198759,"url":"https://github.com/elastic/kibana/pull/198759","mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198759","number":198759,"mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix tablelistview test due to timezone switch (#198759)](#198759) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T11:39:05Z","message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"Fix tablelistview test due to timezone switch","number":198759,"url":"https://github.com/elastic/kibana/pull/198759","mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198759","number":198759,"mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [Fix tablelistview test due to timezone switch (#198759)](#198759) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T11:39:05Z","message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"Fix tablelistview test due to timezone switch","number":198759,"url":"https://github.com/elastic/kibana/pull/198759","mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198759","number":198759,"mergeCommit":{"message":"Fix tablelistview test due to timezone switch (#198759)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/198744\r\n\r\nTest was subtracting 7 days, but there is 1 hour less now, so the test\r\nsetup is incorrect. Fixing it by using moment to handle time switch edge\r\ncase","sha":"a88833c7830c2bb469430eb54c93cab19e64de6e"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #198744
Test was subtracting 7 days, but there is 1 hour less now, so the test setup is incorrect. Fixing it by using moment to handle time switch edge case