[Entity Store] Add enablement errors to entity store management page #198668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiansivive
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
reviewed
Nov 4, 2024
| iconType="alert" | ||
| > | ||
| <p> | ||
| {(deleteEntityEngineMutation.error as { body: { message: string } }).body.message} |
There was a problem hiding this comment.
Is there a way we can add this to the mutation typing?
There was a problem hiding this comment.
probably, there's a refactor issue already here
I'll add a comment there
There was a problem hiding this comment.
useMutation<DataType, ErrorType> receive accepts types, the first is the data and the second the error.
So, the change would be on useInitEntityEngineMutation function.
hop-dev
approved these changes
Nov 4, 2024
machadoum
approved these changes
Nov 4, 2024
|
Starting backport for target branches: 8.16, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
…lastic#198668) ## Summary This PR adds callouts for any errors that occur during entity store enablement and deletion from the management page. These are the same callouts as currently seen in the Entity Analytics dashboard.  (cherry picked from commit 4a0a736)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
…lastic#198668) ## Summary This PR adds callouts for any errors that occur during entity store enablement and deletion from the management page. These are the same callouts as currently seen in the Entity Analytics dashboard.  (cherry picked from commit 4a0a736)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
…t page (#198668) (#198784) # Backport This will backport the following commits from `main` to `8.16`: - [[Entity Store] Add enablement errors to entity store management page (#198668)](#198668) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T13:57:32Z","message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[Entity Store] Add enablement errors to entity store management page","number":198668,"url":"https://github.com/elastic/kibana/pull/198668","mergeCommit":{"message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198668","number":198668,"mergeCommit":{"message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tiago Vila Verde <[email protected]>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
… page (#198668) (#198785) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Store] Add enablement errors to entity store management page (#198668)](#198668) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T13:57:32Z","message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[Entity Store] Add enablement errors to entity store management page","number":198668,"url":"https://github.com/elastic/kibana/pull/198668","mergeCommit":{"message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198668","number":198668,"mergeCommit":{"message":"[Entity Store] Add enablement errors to entity store management page (#198668)\n\n## Summary\r\n\r\nThis PR adds callouts for any errors that occur during entity store\r\nenablement and deletion from the management page. These are the same\r\ncallouts as currently seen in the Entity Analytics dashboard.\r\n\r\n","sha":"4a0a73674e5f51d4296e121537dd59dd63eef589"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tiago Vila Verde <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds callouts for any errors that occur during entity store enablement and deletion from the management page. These are the same callouts as currently seen in the Entity Analytics dashboard.