Fixes flaky backfill tests. #198592
Merged
Fixes flaky backfill tests. #198592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7317[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 173/200 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7319[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 171/200 tests passed. |
ymao1
force-pushed
the
flaky-test-192144-again
branch
from
ad9868d to
f0e94ce
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7320[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 174/200 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7322[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 175/200 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7326[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 172/200 tests passed. |
ymao1
force-pushed
the
flaky-test-192144-again
branch
from
639da5a to
d8ac15a
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7327[✅] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 100/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7328[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 172/200 tests passed. |
ymao1
changed the title
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7336[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 170/200 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7338[✅] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 200/200 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7342[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 173/200 tests passed. |
ymao1
force-pushed
the
flaky-test-192144-again
branch
from
e89908f to
e2344f8
Compare
ymao1
commented
Nov 6, 2024
| @@ -263,11 +263,11 @@ export default function apiKeyBackfillTests({ getService }: FtrProviderContext) | |||
| } | |||
| }); | |||
|
|
|||
| // invoke the invalidate task | |||
| await runInvalidateTask(); | |||
|
|
|||
| // pending API key should now be deleted because backfill is done | |||
| await retry.try(async () => { | |||
There was a problem hiding this comment.
Seems like sometimes the last API key is not invalidated so moving this into the retry loop to retry to invalidate task as well.
ymao1
commented
Nov 6, 2024
| @@ -759,7 +759,7 @@ export default function scheduleBackfillTests({ getService }: FtrProviderContext | |||
| }); | |||
|
|
|||
| it('should handle schedule request where some requests succeed and some requests fail appropriately', async () => { | |||
| const start = moment().utc().startOf('day').subtract(7, 'days').toISOString(); | |||
| const start = moment().utc().startOf('day').subtract(14, 'days').toISOString(); | |||
There was a problem hiding this comment.
increasing the length of the backfill run because occasionally, checking AAD at the end of the this test would return a saved object not found error.
ymao1
commented
Nov 6, 2024
| @@ -167,7 +166,7 @@ export default function createBackfillTaskRunnerTests({ getService }: FtrProvide | |||
| objectRemover.add(spaceId, ruleId, 'rule', 'alerting'); | |||
|
|
|||
| const start = moment(originalDocTimestamps[1]).utc().startOf('day').toISOString(); | |||
| const end = moment().utc().startOf('day').subtract(9, 'days').toISOString(); | |||
| const end = moment(originalDocTimestamps[11]).utc().startOf('day').toISOString(); | |||
There was a problem hiding this comment.
fixing the end timestamp so it relates to the doc timestamps and not to the current time.
ymao1
changed the title
💚 Build Succeeded
Metrics [docs]
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7345[❌] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 173/200 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7346[✅] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 200/200 tests passed. |
ymao1
added
Feature:Alerting
release_note:skip
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7347[✅] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts: 200/200 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
Resolves elastic#192144 Resolves elastic#198168 Resolves elastic#197239 ## Summary Minor fixes to the backfill functional tests to try to reduce flakiness. (cherry picked from commit 705c503)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fixes flaky backfill tests. (#198592)](#198592) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T12:49:36Z","message":"Fixes flaky backfill tests. (#198592)\n\nResolves https://github.com/elastic/kibana/issues/192144\r\nResolves https://github.com/elastic/kibana/issues/198168\r\nResolves https://github.com/elastic/kibana/issues/197239\r\n\r\n## Summary\r\n\r\nMinor fixes to the backfill functional tests to try to reduce flakiness.","sha":"705c503182bce91aa8b717febe508ba29ca2d8c6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"Fixes flaky backfill tests.","number":198592,"url":"https://github.com/elastic/kibana/pull/198592","mergeCommit":{"message":"Fixes flaky backfill tests. (#198592)\n\nResolves https://github.com/elastic/kibana/issues/192144\r\nResolves https://github.com/elastic/kibana/issues/198168\r\nResolves https://github.com/elastic/kibana/issues/197239\r\n\r\n## Summary\r\n\r\nMinor fixes to the backfill functional tests to try to reduce flakiness.","sha":"705c503182bce91aa8b717febe508ba29ca2d8c6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198592","number":198592,"mergeCommit":{"message":"Fixes flaky backfill tests. (#198592)\n\nResolves https://github.com/elastic/kibana/issues/192144\r\nResolves https://github.com/elastic/kibana/issues/198168\r\nResolves https://github.com/elastic/kibana/issues/197239\r\n\r\n## Summary\r\n\r\nMinor fixes to the backfill functional tests to try to reduce flakiness.","sha":"705c503182bce91aa8b717febe508ba29ca2d8c6"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
Resolves elastic#192144 Resolves elastic#198168 Resolves elastic#197239 ## Summary Minor fixes to the backfill functional tests to try to reduce flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192144
Resolves #198168
Resolves #197239
Summary
Minor fixes to the backfill functional tests to try to reduce flakiness.