More logging

elastic · Nov 6, 2024 · e89908f · e89908f
1 parent 4d31e0b
commit e89908f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/x-pack/plugins/alerting/server/invalidate_pending_api_keys/task.ts b/x-pack/plugins/alerting/server/invalidate_pending_api_keys/task.ts
@@ -205,6 +205,7 @@ export async function runInvalidate({
         apiKeySOsPendingInvalidation: apiKeysToInvalidate,
         encryptedSavedObjectsClient,
         savedObjectsClient,
+        logger,
       });
       logger.info(
         `API KEY INVALIDATION TASK: apiKeyIdsToExclude ${JSON.stringify(apiKeyIdsToExclude)}`
@@ -231,6 +232,7 @@ interface GetApiKeyIdsToInvalidateOpts {
   apiKeySOsPendingInvalidation: SavedObjectsFindResponse<InvalidatePendingApiKey>;
   encryptedSavedObjectsClient: EncryptedSavedObjectsClient;
   savedObjectsClient: SavedObjectsClientContract;
+  logger: Logger;
 }
 
 interface GetApiKeysToInvalidateResult {
@@ -242,6 +244,7 @@ export async function getApiKeyIdsToInvalidate({
   apiKeySOsPendingInvalidation,
   encryptedSavedObjectsClient,
   savedObjectsClient,
+  logger,
 }: GetApiKeyIdsToInvalidateOpts): Promise<GetApiKeysToInvalidateResult> {
   // Decrypt the apiKeyId for each pending invalidation SO
   const apiKeyIds = await Promise.all(
@@ -280,6 +283,8 @@ export async function getApiKeyIdsToInvalidate({
     },
   });
 
+  logger.info(`API KEY INVALIDATION TASK: aggregation result ${JSON.stringify(aggregations)}`);
+
   const apiKeyIdsInUseBuckets: AggregationsStringTermsBucketKeys[] =
     (aggregations?.apiKeyId?.buckets as AggregationsStringTermsBucketKeys[]) ?? [];
 

diff --git a/...st/alerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/api_key.ts b/...st/alerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/api_key.ts
@@ -263,15 +263,16 @@ export default function apiKeyBackfillTests({ getService }: FtrProviderContext)
           await getAdHocRunSO(backfillId);
           throw new Error('should have thrown');
         } catch (e) {
+          log.info(`getAdHocRunSO error ${e.message}`);
           expect(e.message).not.to.eql('should have thrown');
         }
       });
 
-      // invoke the invalidate task
-      await runInvalidateTask();
-
       // pending API key should now be deleted because backfill is done
       await retry.try(async () => {
+        // invoke the invalidate task
+        await runInvalidateTask();
+
         const results = await getApiKeysPendingInvalidation();
         log.info(`results 3 ${JSON.stringify(results)}`);
         expect(results.length).to.eql(0);