Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add Esc key handling to lens_configuration_flyout #198487

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[Lens] Add Esc key handling to lens_configuration_flyout #198487

merged 3 commits into from
Nov 4, 2024

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Oct 31, 2024 •
edited by kibanamachine
Loading

Summary

This PR adds Esc key handling to LensEditConfigurationFlyout

Closes: #175100

@kowalczyk-krzysztof kowalczyk-krzysztof added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 31, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 31, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner October 31, 2024 10:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

mbondyra
mbondyra approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +213.0B

History

cc @kowalczyk-krzysztof

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 79331d5 into elastic:main Nov 4, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11665751793

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2024
@kowalczyk-krzysztof
[Lens] Add Esc key handling to lens_configuration_flyout (elastic#198487
da18801 
)

## Summary

This PR adds `Esc` key handling to `LensEditConfigurationFlyout`

Closes: elastic#175100
(cherry picked from commit 79331d5)
@kibanamachine kibanamachine mentioned this pull request Nov 4, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 4, 2024
Merged
kibanamachine added a commit that referenced this pull request Nov 4, 2024
@kibanamachine @kowalczyk-krzysztof
[8.x] [Lens] Add Esc key handling to lens_configuration_flyout (#198487…
a0ce46b 
…) (#198789)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Add Esc key handling to lens_configuration_flyout
(#198487)](#198487)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:01:08Z","message":"[Lens]
Add Esc key handling to lens_configuration_flyout (#198487)\n\n##
Summary\r\n\r\nThis PR adds `Esc` key handling to
`LensEditConfigurationFlyout`\r\n\r\nCloses:
#175100","sha":"79331d53e4239eaefb006072aa316572b75f480d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens]
Add Esc key handling to
lens_configuration_flyout","number":198487,"url":"https://github.com/elastic/kibana/pull/198487","mergeCommit":{"message":"[Lens]
Add Esc key handling to lens_configuration_flyout (#198487)\n\n##
Summary\r\n\r\nThis PR adds `Esc` key handling to
`LensEditConfigurationFlyout`\r\n\r\nCloses:
#175100","sha":"79331d53e4239eaefb006072aa316572b75f480d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198487","number":198487,"mergeCommit":{"message":"[Lens]
Add Esc key handling to lens_configuration_flyout (#198487)\n\n##
Summary\r\n\r\nThis PR adds `Esc` key handling to
`LensEditConfigurationFlyout`\r\n\r\nCloses:
#175100","sha":"79331d53e4239eaefb006072aa316572b75f480d"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] [Inline editing] Close the push flyout with ESC
4 participants
@kowalczyk-krzysztof @elasticmachine @kibanamachine @mbondyra