Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all risk score decimal places consistent #198450

Merged
merged 20 commits into from
Nov 8, 2024
Merged

Make all risk score decimal places consistent #198450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f04af45
updated all rounding on risk scores to use custom formatter to 2DP
CAWilson94 Oct 30, 2024
822ec29
Merge branch 'elastic:main' into main
CAWilson94 Oct 30, 2024
847f3f9
Update index.tsx
CAWilson94 Oct 31, 2024
be2a037
commit import for formatRiskScore on hook use entities list column
CAWilson94 Oct 31, 2024
f23502c
custom field formatter for alerts risk score with helper
CAWilson94 Nov 1, 2024
f5a8eb3
Merge branch 'main' into main
CAWilson94 Nov 5, 2024
a20a24b
removed unused imports
CAWilson94 Nov 5, 2024
2cdba5d
updated data-test-subj for cypress tests
CAWilson94 Nov 5, 2024
e53c31f
jest test to test riskscore returns formatted value when value applie…
CAWilson94 Nov 5, 2024
84723a3
Merge branch 'main' into main
CAWilson94 Nov 5, 2024
9251942
added risk score formatter to be consistent with other security scree…
CAWilson94 Nov 6, 2024
5e76d2b
Merge branch 'main' into main
CAWilson94 Nov 6, 2024
a9f10e5
remove unused import
CAWilson94 Nov 6, 2024
4cb4044
remove unused import
CAWilson94 Nov 6, 2024
0579848
Merge branch 'main' into main
CAWilson94 Nov 6, 2024
492e9c3
Merge branch 'main' into main
CAWilson94 Nov 6, 2024
4b4596a
cypress test formatting added
CAWilson94 Nov 7, 2024
de12cb7
Merge branch 'main' into main
CAWilson94 Nov 7, 2024
7066db5
Merge branch 'elastic:main' into main
CAWilson94 Nov 8, 2024
81f9cdf
Merge branch 'main' into main
CAWilson94 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...urity_solution/public/entity_analytics/components/entity_analytics_risk_score/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
SecurityCellActionType,
} from '../../../common/components/cell_actions';
import { FormattedRelativePreferenceDate } from '../../../common/components/formatted_date';
import { formatRiskScore } from '../../common';

type HostRiskScoreColumns = Array<EuiBasicTableColumn<HostRiskScore & UserRiskScore>>;

Expand Down Expand Up @@ -128,7 +129,7 @@ export const getRiskScoreColumns = (
if (riskScore != null) {
return (
<span data-test-subj="risk-score-truncate" title={`${riskScore}`}>
{Math.round(riskScore)}
{formatRiskScore(riskScore)}
</span>
);
}
Expand Down
3 changes: 2 additions & 1 deletion ...ution/public/entity_analytics/components/entity_store/hooks/use_entities_list_columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { type CriticalityLevels } from '../../../../../common/constants';
import { ENTITIES_LIST_TABLE_ID } from '../constants';
import { isUserEntity, sourceFieldToText } from '../helpers';
import { CRITICALITY_LEVEL_TITLE } from '../../asset_criticality/translations';
import { formatRiskScore } from '../../../common';

export type EntitiesListColumns = [
Columns<Entity>,
Expand Down Expand Up @@ -149,7 +150,7 @@ export const useEntitiesListColumns = (): EntitiesListColumns => {
if (riskScore != null) {
return (
<span data-test-subj="risk-score-truncate" title={`${riskScore}`}>
{Math.round(riskScore)}
{formatRiskScore(riskScore)}
</span>
);
}
Expand Down
3 changes: 2 additions & 1 deletion ...ns/security_solution/public/entity_analytics/components/host_risk_score_table/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { RiskScoreLevel } from '../severity/common';
import { ENTITY_RISK_LEVEL } from '../risk_score/translations';
import { CELL_ACTIONS_TELEMETRY } from '../risk_score/constants';
import { FormattedRelativePreferenceDate } from '../../../common/components/formatted_date';
import { formatRiskScore } from '../../common';

export const getHostRiskScoreColumns = ({
dispatchSeverityUpdate,
Expand Down Expand Up @@ -82,7 +83,7 @@ export const getHostRiskScoreColumns = ({
if (riskScore != null) {
return (
<span data-test-subj="risk-score-truncate" title={`${riskScore}`}>
{Math.round(riskScore)}
{formatRiskScore(riskScore)}
</span>
);
}
Expand Down
3 changes: 2 additions & 1 deletion ...ns/security_solution/public/entity_analytics/components/user_risk_score_table/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { UsersTableType } from '../../../explore/users/store/model';
import { ENTITY_RISK_LEVEL } from '../risk_score/translations';
import { CELL_ACTIONS_TELEMETRY } from '../risk_score/constants';
import { FormattedRelativePreferenceDate } from '../../../common/components/formatted_date';
import { formatRiskScore } from '../../common';

export const getUserRiskScoreColumns = ({
dispatchSeverityUpdate,
Expand Down Expand Up @@ -85,7 +86,7 @@ export const getUserRiskScoreColumns = ({
if (riskScore != null) {
return (
<span data-test-subj="risk-score-truncate" title={`${riskScore}`}>
{Math.round(riskScore)}
{formatRiskScore(riskScore)}
</span>
);
}
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/hosts/host_risk_tab.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('risk tab', { tags: ['@ess'] }, () => {
kqlSearch('host.name: "siem-kibana" {enter}');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(4).should('have.text', 'siem-kibana');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(5).should('have.text', 'Mar 10, 2021 @ 14:51:05.766');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(6).should('have.text', '21');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(6).should('have.text', '21.00');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(7).should('have.text', 'Low');
});

Expand Down Expand Up @@ -93,7 +93,7 @@ describe('risk tab', { tags: ['@ess'] }, () => {
kqlSearch('host.name: "siem-kibana" {enter}');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(4).should('have.text', 'siem-kibana');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(5).should('have.text', 'Mar 10, 2021 @ 14:51:05.766');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(6).should('have.text', '90');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(6).should('have.text', '90.00');
cy.get(HOST_BY_RISK_TABLE_CELL).eq(7).should('have.text', 'Critical');
});

Expand Down