Make all risk score decimal places consistent #198450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amended mistake quotations in selectedOption entityName
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
CAWilson94
added
Theme: entity_analytics
v8.17.0
backport:version
machadoum
reviewed
Nov 5, 2024
...ity_solution/public/timelines/components/timeline/body/renderers/formatted_field_helpers.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/public/timelines/components/timeline/body/renderers/formatted_field_helpers.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I feel like we should also use the formatRiskScore function in the alert details flyout also? (see here).
Wdyt?
The flyout is accessed by pressing on the double arrow icon on the alerts table
...ns/security_solution/public/timelines/components/timeline/body/renderers/formatted_field.tsx
Outdated
Show resolved
Hide resolved
…d, or does not render when no value applied
CAWilson94
commented
Nov 6, 2024
x-pack/plugins/security_solution/public/flyout/document_details/right/components/risk_score.tsx
Outdated
Show resolved
Hide resolved
|
@PhilippeOberti @CAWilson94 I don't think we should format the Alert risk score with |
|
@machadoum this is the same for alerts page and the flyout - the risk score here is coming from the search strategy functions which seem to utilise the field API. So, for both cases under alerts, I can revert that risk score formatting change. I think that makes sense. My note here is partially confirmation of findings for my own understanding. 😁 |
|
@machadoum @PhilippeOberti Hello, updated to only format risk score on host and user entities, reverted the alert risk score changes. Thanks! :) |
There was a problem hiding this comment.
Thanks for making these changes @CAWilson94. The @elastic/security-threat-hunting-investigations team is no longer a code owner here so my approval has no value! 😆
I see that some ESS and serverless Cypress test are failing, feel free to reach out if you need any help troubleshooting these!
CAWilson94
added
v9.0.0
v8.16.0
release_note:skip
tiansivive
approved these changes
Nov 8, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @CAWilson94 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
## Summary This PR updates risk scores to use formatter to 2DP instead of basic Math.round for consistency and accuracy.    With reverted alert score, showing user and host risk scores still have formatting:  (cherry picked from commit 4b6b1c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Make all risk score decimal places consistent (#198450)](#198450) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Charlotte Alexandra Wilson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T16:33:50Z","message":"Make all risk score decimal places consistent (#198450)\n\n## Summary\r\n\r\nThis PR updates risk scores to use formatter to 2DP instead of basic\r\nMath.round for consistency and accuracy.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nWith reverted alert score, showing user and host risk scores still have\r\nformatting:\r\n\r\n\r\n","sha":"4b6b1c3effaf9918f8332a21af42409092fd8ed5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Theme: entity_analytics","Team:Entity Analytics","backport:version","v8.17.0"],"title":"Make all risk score decimal places consistent","number":198450,"url":"https://github.com/elastic/kibana/pull/198450","mergeCommit":{"message":"Make all risk score decimal places consistent (#198450)\n\n## Summary\r\n\r\nThis PR updates risk scores to use formatter to 2DP instead of basic\r\nMath.round for consistency and accuracy.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nWith reverted alert score, showing user and host risk scores still have\r\nformatting:\r\n\r\n\r\n","sha":"4b6b1c3effaf9918f8332a21af42409092fd8ed5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198450","number":198450,"mergeCommit":{"message":"Make all risk score decimal places consistent (#198450)\n\n## Summary\r\n\r\nThis PR updates risk scores to use formatter to 2DP instead of basic\r\nMath.round for consistency and accuracy.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nWith reverted alert score, showing user and host risk scores still have\r\nformatting:\r\n\r\n\r\n","sha":"4b6b1c3effaf9918f8332a21af42409092fd8ed5"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Charlotte Alexandra Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates risk scores to use formatter to 2DP instead of basic Math.round for consistency and accuracy.
With reverted alert score, showing user and host risk scores still have formatting: