Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search bar/timepicker for logs only services #198296

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

Bluefinger
Copy link
Contributor

@Bluefinger Bluefinger commented Oct 30, 2024

Summary

Enables logs only Services to have a timepicker in the logs tab.

Screenshot 2024-10-31 181045

How to test

  • Use node scripts/synthtrace traces_logs_entities.ts --clean --live
  • Navigate to synth-go-logs service, go to logs tab
  • Timepicker should be visible and work to filter available logs

Closes #197604

@Bluefinger Bluefinger added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 30, 2024
@Bluefinger
Copy link
Contributor Author

@elasticmachine merge upstream

@Bluefinger Bluefinger marked this pull request as ready for review October 31, 2024 17:11
@Bluefinger Bluefinger requested a review from a team as a code owner October 31, 2024 17:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@Bluefinger Bluefinger added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 and removed backport:skip This commit does not require backporting labels Oct 31, 2024
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@Bluefinger
Copy link
Contributor Author

@elasticmachine merge upstream

@Bluefinger Bluefinger enabled auto-merge (squash) November 4, 2024 09:40
@Bluefinger
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: c2740c1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198296-c2740c131e51

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB -103.0B

History

@Bluefinger Bluefinger merged commit 12dc826 into elastic:main Nov 4, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11665313232

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2024
## Summary

Enables logs only Services to have a timepicker in the logs tab.

![Screenshot 2024-10-31
181045](https://github.com/user-attachments/assets/0026af42-313c-4aa5-82b3-5f726d3e52d0)

### How to test

- Use `node scripts/synthtrace traces_logs_entities.ts --clean --live`
- Navigate to `synth-go-logs` service, go to logs tab
- Timepicker should be visible and work to filter available logs

Closes elastic#197604

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 12dc826)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 4, 2024
…198782)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Enable search bar/timepicker for logs only services
(#198296)](#198296)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T13:34:51Z","message":"Enable
search bar/timepicker for logs only services (#198296)\n\n##
Summary\r\n\r\nEnables logs only Services to have a timepicker in the
logs tab.\r\n\r\n![Screenshot
2024-10-31\r\n181045](https://github.com/user-attachments/assets/0026af42-313c-4aa5-82b3-5f726d3e52d0)\r\n\r\n###
How to test\r\n\r\n- Use `node scripts/synthtrace
traces_logs_entities.ts --clean --live`\r\n- Navigate to `synth-go-logs`
service, go to logs tab\r\n- Timepicker should be visible and work to
filter available logs\r\n\r\nCloses #197604\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"12dc8264bd422b659a7b0438d52bc6ed7a7a7bc4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"title":"Enable
search bar/timepicker for logs only
services","number":198296,"url":"https://github.com/elastic/kibana/pull/198296","mergeCommit":{"message":"Enable
search bar/timepicker for logs only services (#198296)\n\n##
Summary\r\n\r\nEnables logs only Services to have a timepicker in the
logs tab.\r\n\r\n![Screenshot
2024-10-31\r\n181045](https://github.com/user-attachments/assets/0026af42-313c-4aa5-82b3-5f726d3e52d0)\r\n\r\n###
How to test\r\n\r\n- Use `node scripts/synthtrace
traces_logs_entities.ts --clean --live`\r\n- Navigate to `synth-go-logs`
service, go to logs tab\r\n- Timepicker should be visible and work to
filter available logs\r\n\r\nCloses #197604\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"12dc8264bd422b659a7b0438d52bc6ed7a7a7bc4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198296","number":198296,"mergeCommit":{"message":"Enable
search bar/timepicker for logs only services (#198296)\n\n##
Summary\r\n\r\nEnables logs only Services to have a timepicker in the
logs tab.\r\n\r\n![Screenshot
2024-10-31\r\n181045](https://github.com/user-attachments/assets/0026af42-313c-4aa5-82b3-5f726d3e52d0)\r\n\r\n###
How to test\r\n\r\n- Use `node scripts/synthtrace
traces_logs_entities.ts --clean --live`\r\n- Navigate to `synth-go-logs`
service, go to logs tab\r\n- Timepicker should be visible and work to
filter available logs\r\n\r\nCloses #197604\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"12dc8264bd422b659a7b0438d52bc6ed7a7a7bc4"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Entities] Add time picker to Logs tab when service only has logs
5 participants