[ResponseOps][Cases]Allow users to push to external service when the case is closed #198146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgianaonoleata1904
added
enhancement
|
Pinging @elastic/response-ops (Team:ResponseOps) |
js-jankisalvi
approved these changes
Nov 1, 2024
x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx
Show resolved
Hide resolved
…rgianaonoleata1904/kibana into push-external-service-192552
adcoelho
reviewed
Nov 7, 2024
| @@ -460,7 +438,7 @@ describe('usePushToService', () => { | |||
| const { result } = renderHook< | |||
| React.PropsWithChildren<UsePushToService>, | |||
| ReturnUsePushToService | |||
| >(() => usePushToService({ ...defaultArgs, caseStatus: CaseStatuses.closed }), { | |||
| >(() => usePushToService({ ...defaultArgs, isValidConnector: false }), { | |||
There was a problem hiding this comment.
'hasErrorMessages=true if there are error messages' so is isValidConnector: false just a different way of throwing an error?
There was a problem hiding this comment.
Yes, I thought I can replace the caseStatus: CaseStatuses.closed with isValidConnector: false just to be able to throw an error in this case.
adcoelho
approved these changes
Nov 7, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
…case is closed (elastic#198146) Closes elastic#192552 ## Summary - Removed the restriction that didn't allow user to push a closed case to an external service. https://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Antonio <[email protected]> (cherry picked from commit cc6ffef)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
…case is closed (elastic#198146) Closes elastic#192552 ## Summary - Removed the restriction that didn't allow user to push a closed case to an external service. https://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Antonio <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
…n the case is closed (#198146) (#199428) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases]Allow users to push to external service when the case is closed (#198146)](#198146) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T09:32:11Z","message":"[ResponseOps][Cases]Allow users to push to external service when the case is closed (#198146)\n\nCloses https://github.com/elastic/kibana/issues/192552\r\n\r\n## Summary\r\n\r\n- Removed the restriction that didn't allow user to push a closed case\r\nto an external service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Antonio <[email protected]>","sha":"cc6ffef06c30134dafcd40946659d41a38f63d56","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[ResponseOps][Cases]Allow users to push to external service when the case is closed","number":198146,"url":"https://github.com/elastic/kibana/pull/198146","mergeCommit":{"message":"[ResponseOps][Cases]Allow users to push to external service when the case is closed (#198146)\n\nCloses https://github.com/elastic/kibana/issues/192552\r\n\r\n## Summary\r\n\r\n- Removed the restriction that didn't allow user to push a closed case\r\nto an external service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Antonio <[email protected]>","sha":"cc6ffef06c30134dafcd40946659d41a38f63d56"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198146","number":198146,"mergeCommit":{"message":"[ResponseOps][Cases]Allow users to push to external service when the case is closed (#198146)\n\nCloses https://github.com/elastic/kibana/issues/192552\r\n\r\n## Summary\r\n\r\n- Removed the restriction that didn't allow user to push a closed case\r\nto an external service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Antonio <[email protected]>","sha":"cc6ffef06c30134dafcd40946659d41a38f63d56"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
…case is closed (elastic#198146) Closes elastic#192552 ## Summary - Removed the restriction that didn't allow user to push a closed case to an external service. https://github.com/user-attachments/assets/82c49524-5685-40c0-b025-d6b38ab4e056 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Antonio <[email protected]>
|
@georgianaonoleata1904 Thank you for working on this. We faced issues sending the "Closed" case status to the external system and this should probably help with that.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192552
Summary
Screen.Recording.2024-10-30.at.13.39.43.mov