[8.x] [ResponseOps][Cases]Allow users to push to external service whe…

…n the case is closed (#198146) (#199428) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases]Allow users to push to external service when the case is closed (#198146)](#198146)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Georgiana-Andreea Onoleață <[email protected]>
elastic · Nov 8, 2024 · beb7cfa · beb7cfa
1 parent 418281b
commit beb7cfa
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 39 deletions.
diff --git a/x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx b/x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx
@@ -13,7 +13,6 @@ import { usePushToService } from '.';
 import { noPushCasesPermissions, readCasesPermissions, TestProviders } from '../../common/mock';
 import { usePostPushToService } from '../../containers/use_post_push_to_service';
 import { actionLicenses } from '../../containers/mock';
-import { CLOSED_CASE_PUSH_ERROR_ID } from './callout/types';
 import { useGetActionLicense } from '../../containers/use_get_action_license';
 import { getCaseConnectorsMockResponse } from '../../common/mock/connectors';
 import { useRefreshCaseViewPage } from '../case_view/use_on_refresh_case_view_page';
@@ -182,27 +181,6 @@ describe('usePushToService', () => {
     expect(result.current.hasErrorMessages).toBe(true);
   });
 
-  it('Displays message when case is closed', async () => {
-    const { result } = renderHook<
-      React.PropsWithChildren<UsePushToService>,
-      ReturnUsePushToService
-    >(
-      () =>
-        usePushToService({
-          ...defaultArgs,
-          caseStatus: CaseStatuses.closed,
-        }),
-      {
-        wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
-      }
-    );
-
-    const errorsMsg = result.current.errorsMsg;
-    expect(errorsMsg).toHaveLength(1);
-    expect(errorsMsg[0].id).toEqual(CLOSED_CASE_PUSH_ERROR_ID);
-    expect(result.current.hasErrorMessages).toBe(true);
-  });
-
   it('should not call pushCaseToExternalService when the selected connector is none', async () => {
     const { result } = renderHook<
       React.PropsWithChildren<UsePushToService>,
@@ -460,7 +438,7 @@ describe('usePushToService', () => {
       const { result } = renderHook<
         React.PropsWithChildren<UsePushToService>,
         ReturnUsePushToService
-      >(() => usePushToService({ ...defaultArgs, caseStatus: CaseStatuses.closed }), {
+      >(() => usePushToService({ ...defaultArgs, isValidConnector: false }), {
         wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
       });
 

diff --git a/x-pack/plugins/cases/public/components/use_push_to_service/index.tsx b/x-pack/plugins/cases/public/components/use_push_to_service/index.tsx
@@ -13,10 +13,8 @@ import {
   getKibanaConfigError,
   getConnectorMissingInfo,
   getDeletedConnectorError,
-  getCaseClosedInfo,
 } from './helpers';
 import type { CaseConnector } from '../../../common/types/domain';
-import { CaseStatuses } from '../../../common/types/domain';
 import type { ErrorMessage } from './callout/types';
 import { useRefreshCaseViewPage } from '../case_view/use_on_refresh_case_view_page';
 import { useGetActionLicense } from '../../containers/use_get_action_license';
@@ -44,7 +42,6 @@ export interface ReturnUsePushToService {
 
 export const usePushToService = ({
   caseId,
-  caseStatus,
   caseConnectors,
   connector,
   isValidConnector,
@@ -108,14 +105,9 @@ export const usePushToService = ({
       return [getDeletedConnectorError()];
     }
 
-    if (caseStatus === CaseStatuses.closed) {
-      return [getCaseClosedInfo()];
-    }
-
     return errors;
   }, [
     actionLicense,
-    caseStatus,
     connector.id,
     hasLicenseError,
     isValidConnector,

diff --git a/x-pack/plugins/cases/server/client/cases/push.ts b/x-pack/plugins/cases/server/client/cases/push.ts
@@ -140,12 +140,6 @@ export const push = async (
       operation: Operations.pushCase,
     });
 
-    if (theCase?.status === CaseStatuses.closed) {
-      throw Boom.conflict(
-        `The ${theCase.title} case is closed. Pushing a closed case is not allowed.`
-      );
-    }
-
     const alertsInfo = getAlertInfoFromComments(theCase?.comments);
     const alerts = await getAlerts(alertsInfo, clientArgs);
     const profiles = await getProfiles(theCase, securityStartPlugin);

diff --git a/x-pack/test/cases_api_integration/security_and_spaces/tests/trial/cases/push_case.ts b/x-pack/test/cases_api_integration/security_and_spaces/tests/trial/cases/push_case.ts
@@ -488,7 +488,7 @@ export default ({ getService }: FtrProviderContext): void => {
         });
       });
 
-      it('unhappy path = 409s when case is closed', async () => {
+      it('should push a closed case', async () => {
         const { postedCase, connector } = await createCaseWithConnector({
           supertest,
           serviceNowSimulatorURL,
@@ -511,7 +511,7 @@ export default ({ getService }: FtrProviderContext): void => {
           supertest,
           caseId: postedCase.id,
           connectorId: connector.id,
-          expectedHttpCode: 409,
+          expectedHttpCode: 200,
         });
       });