Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Remove plugin build #197125

Merged
merged 8 commits into from
Nov 6, 2024
Merged

[ci] Remove plugin build #197125

merged 8 commits into from
Nov 6, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 21, 2024 •
edited by kibanamachine
Loading

The platform plugin builds were used when functional tests were, at times, run from source.
This is mostly no longer a requirement. There are two remaining cypress scripts that I updated to use the build instead.

With the time saved I'm dropping the number of vCPUs from 16 to 8. These are mostly underutilized by this step, with the exception of the distribution plugin build.

jbudz added 2 commits October 21, 2024 14:06
@jbudz
[ci] Remove plugin build
90e34ed 
The platform plugin builds were used at a time when functional tests
were, at times, run from source.

This is mostly no longer a requirement. There are two remaining cypress
scripts that I updated to use the build instead.
@jbudz
echo
9d896f5
@jbudz
Copy link
Member Author

jbudz commented Oct 21, 2024

buildkite test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2024

Build testing the defend workflows changes: https://buildkite.com/elastic/kibana-pull-request/builds/247852

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 1, 2024
@jbudz
Copy link
Member Author

jbudz commented Nov 4, 2024

buildkite test this

@jbudz jbudz requested a review from a team November 4, 2024 23:23
@jbudz jbudz marked this pull request as ready for review November 4, 2024 23:23
@jbudz jbudz requested review from a team as code owners November 4, 2024 23:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz requested review from a team, pzl and szwarckonrad and removed request for a team November 4, 2024 23:23
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@jbudz jbudz merged commit 6b7c5b9 into elastic:main Nov 6, 2024
26 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11710943161

@jbudz
Copy link
Member Author

jbudz commented Nov 6, 2024

I'm going to leave the backport unresolved for a while to monitor for issues. This expectation has been built in to most of our test pipelines for years, there's a decent chance I missed something and will need to revert.

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Security Solution] Adds UI support for filtering by rule source customization (#197340)
- [unified-data-table] clean up another SASS compilation warnings (#199176)
- Remove deprecated usages of EuiFormRow's display="columnCompressedSwitch" prop (#198709)
- Pass bulkPartialUpdate errors to taskStore.errors (#198606)
- [SecuritySolution][SIEM migrations] Implement background task API (#197997)
- [Dataset quality] Extracting totalDocs form degradedDocs request (#198757)
- [Search] Move ConnectorDefinition types and consts (#197676)
- Address some of the no_group_crossing dependencies (#198261)
- [SecuritySolution] Check user permissions before initialising entity engine (#198661)

Manual backport

To create the backport manually run:

node scripts/backport --pr 197125

Questions ?

Please refer to the Backport tool documentation

mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
@jbudz @mgadewoll
[ci] Remove plugin build (elastic#197125)
8a3f1be 
The platform plugin builds were used when functional tests were, at
times, run from source.
This is mostly no longer a requirement. There are two remaining cypress
scripts that I updated to use the build instead.

With the time saved I'm dropping the number of vCPUs from 16 to 8. These
are mostly underutilized by this step, with the exception of the
distribution plugin build.
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197125 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 7, 2024
jbudz added a commit to jbudz/kibana that referenced this pull request Nov 7, 2024
@jbudz
[ci] Remove plugin build (elastic#197125)
0e0cfbd 
The platform plugin builds were used when functional tests were, at
times, run from source.
This is mostly no longer a requirement. There are two remaining cypress
scripts that I updated to use the build instead.

With the time saved I'm dropping the number of vCPUs from 16 to 8. These
are mostly underutilized by this step, with the exception of the
distribution plugin build.
@jbudz jbudz mentioned this pull request Nov 7, 2024
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

6 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jbudz added a commit that referenced this pull request Nov 25, 2024
@jbudz
[8.x][ci] Remove plugin build (#197125) (#199380)
d152212 
#197125
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 25, 2024
@pheyos pheyos mentioned this pull request Jan 8, 2025
Merged
pheyos added a commit that referenced this pull request Jan 8, 2025
@pheyos
Remove usage of Kibana plugins build in performance test pipelines (#…
9bdc995 
…205896)

## Summary

This PR fixes the performance test pipelines by removing the bits that
rely on the plugins build.

### Details

* The plugin build has been removed with #197125. Since the performance
pipelines are running against a Kibana build (and not against sources),
they should not need the plugin build.
* The `performance-data-set-extraction` pipeline started to fail
immediately after the plugin build has been removed
* This failure went unnoticed since the `scalability-benchmarking`
pipeline continued to work by using the last uploaded artifacts from the
`performance-data-set-extraction` pipeline, which were available for
another month. Once the old artifacts were no longer available, the
`scalability-benchmarking` pipeline also started to fail.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2025
@pheyos
Remove usage of Kibana plugins build in performance test pipelines (e…
8cf7e09 
…lastic#205896)

## Summary

This PR fixes the performance test pipelines by removing the bits that
rely on the plugins build.

### Details

* The plugin build has been removed with elastic#197125. Since the performance
pipelines are running against a Kibana build (and not against sources),
they should not need the plugin build.
* The `performance-data-set-extraction` pipeline started to fail
immediately after the plugin build has been removed
* This failure went unnoticed since the `scalability-benchmarking`
pipeline continued to work by using the last uploaded artifacts from the
`performance-data-set-extraction` pipeline, which were available for
another month. Once the old artifacts were no longer available, the
`scalability-benchmarking` pipeline also started to fail.

(cherry picked from commit 9bdc995)
kibanamachine added a commit that referenced this pull request Jan 9, 2025
@kibanamachine @pheyos
[8.x] Remove usage of Kibana plugins build in performance test pipeli…
5106868 
…nes (#205896) (#205930)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove usage of Kibana plugins build in performance test pipelines
(#205896)](#205896)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:15:33Z","message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"Remove
usage of Kibana plugins build in performance test
pipelines","number":205896,"url":"https://github.com/elastic/kibana/pull/205896","mergeCommit":{"message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205896","number":205896,"mergeCommit":{"message":"Remove
usage of Kibana plugins build in performance test pipelines
(#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test
pipelines by removing the bits that\r\nrely on the plugins
build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed
with #197125. Since the performance\r\npipelines are running against a
Kibana build (and not against sources),\r\nthey should not need the
plugin build.\r\n* The `performance-data-set-extraction` pipeline
started to fail\r\nimmediately after the plugin build has been
removed\r\n* This failure went unnoticed since the
`scalability-benchmarking`\r\npipeline continued to work by using the
last uploaded artifacts from the\r\n`performance-data-set-extraction`
pipeline, which were available for\r\nanother month. Once the old
artifacts were no longer available, the\r\n`scalability-benchmarking`
pipeline also started to
fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@pheyos @CAWilson94
Remove usage of Kibana plugins build in performance test pipelines (e…
b3ff186 
…lastic#205896)

## Summary

This PR fixes the performance test pipelines by removing the bits that
rely on the plugins build.

### Details

* The plugin build has been removed with elastic#197125. Since the performance
pipelines are running against a Kibana build (and not against sources),
they should not need the plugin build.
* The `performance-data-set-extraction` pipeline started to fail
immediately after the plugin build has been removed
* This failure went unnoticed since the `scalability-benchmarking`
pipeline continued to work by using the last uploaded artifacts from the
`performance-data-set-extraction` pipeline, which were available for
another month. Once the old artifacts were no longer available, the
`scalability-benchmarking` pipeline also started to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwarckonrad szwarckonrad szwarckonrad approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@pheyos pheyos pheyos approved these changes

@pzl pzl pzl approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jbudz @elasticmachine @kibanamachine @pzl @pheyos @shahzad31 @dominiqueclarke @Ikuni17 @jennypavlova @szwarckonrad