Remove usage of Kibana plugins build in performance test pipelines #205896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
cc @pheyos |
jbudz
approved these changes
Jan 8, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205896) ## Summary This PR fixes the performance test pipelines by removing the bits that rely on the plugins build. ### Details * The plugin build has been removed with elastic#197125. Since the performance pipelines are running against a Kibana build (and not against sources), they should not need the plugin build. * The `performance-data-set-extraction` pipeline started to fail immediately after the plugin build has been removed * This failure went unnoticed since the `scalability-benchmarking` pipeline continued to work by using the last uploaded artifacts from the `performance-data-set-extraction` pipeline, which were available for another month. Once the old artifacts were no longer available, the `scalability-benchmarking` pipeline also started to fail. (cherry picked from commit 9bdc995)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…nes (#205896) (#205930) # Backport This will backport the following commits from `main` to `8.x`: - [Remove usage of Kibana plugins build in performance test pipelines (#205896)](#205896) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:15:33Z","message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0"],"title":"Remove usage of Kibana plugins build in performance test pipelines","number":205896,"url":"https://github.com/elastic/kibana/pull/205896","mergeCommit":{"message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205896","number":205896,"mergeCommit":{"message":"Remove usage of Kibana plugins build in performance test pipelines (#205896)\n\n## Summary\r\n\r\nThis PR fixes the performance test pipelines by removing the bits that\r\nrely on the plugins build.\r\n\r\n### Details\r\n\r\n* The plugin build has been removed with #197125. Since the performance\r\npipelines are running against a Kibana build (and not against sources),\r\nthey should not need the plugin build.\r\n* The `performance-data-set-extraction` pipeline started to fail\r\nimmediately after the plugin build has been removed\r\n* This failure went unnoticed since the `scalability-benchmarking`\r\npipeline continued to work by using the last uploaded artifacts from the\r\n`performance-data-set-extraction` pipeline, which were available for\r\nanother month. Once the old artifacts were no longer available, the\r\n`scalability-benchmarking` pipeline also started to fail.","sha":"9bdc995d3c6f1c19d242d411e039e1c9c5c6251f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…lastic#205896) ## Summary This PR fixes the performance test pipelines by removing the bits that rely on the plugins build. ### Details * The plugin build has been removed with elastic#197125. Since the performance pipelines are running against a Kibana build (and not against sources), they should not need the plugin build. * The `performance-data-set-extraction` pipeline started to fail immediately after the plugin build has been removed * This failure went unnoticed since the `scalability-benchmarking` pipeline continued to work by using the last uploaded artifacts from the `performance-data-set-extraction` pipeline, which were available for another month. Once the old artifacts were no longer available, the `scalability-benchmarking` pipeline also started to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the performance test pipelines by removing the bits that rely on the plugins build.
Details
performance-data-set-extractionpipeline started to fail immediately after the plugin build has been removedscalability-benchmarkingpipeline continued to work by using the last uploaded artifacts from theperformance-data-set-extractionpipeline, which were available for another month. Once the old artifacts were no longer available, thescalability-benchmarkingpipeline also started to fail.