Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577) #197031

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ing inference endpoints (elastic#196577)

When listing the inference endpoints available for the semantic text
field, we should only list `sparse_embedding` and `text_embedding`
types.

<img width="353" alt="image"
src="https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75">

This PR adds a check to the `data_visualizer/inference_endpoints`
endpoint to ensure only `sparse_embedding` and `text_embedding` types
are used and they have at least one allocation.
NOTE, the allocation check is currently commented out waiting on an es
change. elastic/elasticsearch#115095

Also renames the endpoint from `data_visualizer/inference_services` ->
`data_visualizer/inference_endpoints`
And renames variables which were incorrectly named "service" rather than
"endpoint"

(cherry picked from commit fb412ca)
@kibanamachine kibanamachine merged commit 904d201 into elastic:8.x Oct 21, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / ObservabilityApp Custom threshold rule can add data view

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 615.8KB 615.8KB +2.0B

cc @jgowdyelastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants