[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints #196577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
changed the title
…b.com:jgowdyelastic/kibana into file-upload-filter-running-inference-services
|
Another thing that would be nice to filter is only to show inference APIs for embedding services.
|
…b.com:jgowdyelastic/kibana into file-upload-filter-running-inference-services
peteharverson
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Tested and LGTM.
One observation - in my local testing, uploading a PDF file (500 lines, 160KB) for the first time can take a couple of minutes - presumably as a new .elser-2 deployment is created. During this time, the progress page stays in step 4 (Uploading data) with no visible sign of anything happening. Is there anything we can do to improve the messaging here to provide more details on what is happening?
I'm now filtering for |
Nice! Thanks |
There will be a change going into es for 8.16 which fixes In the future we could add a step to trigger this auto deployment by calling the infer endpoint during upload and report the status of the download and deployment as an addition step in the upload progress. #196696 |
peteharverson
approved these changes
Oct 21, 2024
jgowdyelastic
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…ing inference endpoints (elastic#196577) When listing the inference endpoints available for the semantic text field, we should only list `sparse_embedding` and `text_embedding` types. <img width="353" alt="image" src="https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75"> This PR adds a check to the `data_visualizer/inference_endpoints` endpoint to ensure only `sparse_embedding` and `text_embedding` types are used and they have at least one allocation. NOTE, the allocation check is currently commented out waiting on an es change. elastic/elasticsearch#115095 Also renames the endpoint from `data_visualizer/inference_services` -> `data_visualizer/inference_endpoints` And renames variables which were incorrectly named "service" rather than "endpoint" (cherry picked from commit fb412ca)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…ing inference endpoints (elastic#196577) When listing the inference endpoints available for the semantic text field, we should only list `sparse_embedding` and `text_embedding` types. <img width="353" alt="image" src="https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75"> This PR adds a check to the `data_visualizer/inference_endpoints` endpoint to ensure only `sparse_embedding` and `text_embedding` types are used and they have at least one allocation. NOTE, the allocation check is currently commented out waiting on an es change. elastic/elasticsearch#115095 Also renames the endpoint from `data_visualizer/inference_services` -> `data_visualizer/inference_endpoints` And renames variables which were incorrectly named "service" rather than "endpoint" (cherry picked from commit fb412ca)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…_embedding inference endpoints (#196577) (#197030) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)](#196577) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T10:56:05Z","message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints","number":196577,"url":"https://github.com/elastic/kibana/pull/196577","mergeCommit":{"message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196577","number":196577,"mergeCommit":{"message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…embedding inference endpoints (#196577) (#197031) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)](#196577) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T10:56:05Z","message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug",":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints","number":196577,"url":"https://github.com/elastic/kibana/pull/196577","mergeCommit":{"message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196577","number":196577,"mergeCommit":{"message":"[ML] File data visualizer: only list sparse_embedding and text_embedding inference endpoints (#196577)\n\nWhen listing the inference endpoints available for the semantic text\r\nfield, we should only list `sparse_embedding` and `text_embedding`\r\ntypes.\r\n\r\n<img width=\"353\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/95526f2b-e293-4e01-be79-b87e1ecb9a75\">\r\n\r\n\r\n\r\nThis PR adds a check to the `data_visualizer/inference_endpoints`\r\nendpoint to ensure only `sparse_embedding` and `text_embedding` types\r\nare used and they have at least one allocation.\r\nNOTE, the allocation check is currently commented out waiting on an es\r\nchange. https://github.com/elastic/elasticsearch/pull/115095\r\n\r\nAlso renames the endpoint from `data_visualizer/inference_services` ->\r\n`data_visualizer/inference_endpoints`\r\nAnd renames variables which were incorrectly named \"service\" rather than\r\n\"endpoint\"","sha":"fb412ca0b7dfb997f2f84da62a12f32d3012ffb0"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
jgowdyelastic
added a commit
that referenced
this pull request
Oct 24, 2024
Enables the previously commented out check for `num_allocations` when listing the inference endpoints. The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed. Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095 Follow on from #196577
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
Enables the previously commented out check for `num_allocations` when listing the inference endpoints. The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed. Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095 Follow on from elastic#196577 (cherry picked from commit 66b2447)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
Enables the previously commented out check for `num_allocations` when listing the inference endpoints. The adaptive allocation count can drop to 0, but it is still valid for use. Uploading a file will cause it to be re-deployed. Related to es PRs elastic/elasticsearch#115233 and elastic/elasticsearch#115095 Follow on from elastic#196577 (cherry picked from commit 66b2447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing the inference endpoints available for the semantic text field, we should only list
sparse_embeddingandtext_embeddingtypes.This PR adds a check to the
data_visualizer/inference_endpointsendpoint to ensure onlysparse_embeddingandtext_embeddingtypes are used and they have at least one allocation.NOTE, the allocation check is currently commented out waiting on an es change. elastic/elasticsearch#115095
Also renames the endpoint from
data_visualizer/inference_services->data_visualizer/inference_endpointsAnd renames variables which were incorrectly named "service" rather than "endpoint"