Move consumers off bsearch endpoint #196962
Merged
+177
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
opauloh
approved these changes
Oct 23, 2024
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dmlemeshko
approved these changes
Oct 23, 2024
shahzad31
approved these changes
Oct 23, 2024
angorayc
approved these changes
Oct 23, 2024
lukasolson
added
v9.0.0
release_note:skip
jbudz
approved these changes
Oct 23, 2024
jughosta
reviewed
Oct 29, 2024
x-pack/test_serverless/api_integration/test_suites/common/search_oss/index.ts
Outdated
Show resolved
Hide resolved
…na into remove_bfetch_use_search
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @lukasolson |
davismcphee
approved these changes
Nov 7, 2024
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Part of elastic#186139. Moves direct consumers off of the `internal/bsearch` endpoint and onto the `internal/search`. This is in preparation for removing the `internal/bsearch` endpoint entirely. Updates automated tests to mock/use the correct service moving forward. ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Part of elastic#186139. Moves direct consumers off of the `internal/bsearch` endpoint and onto the `internal/search`. This is in preparation for removing the `internal/bsearch` endpoint entirely. Updates automated tests to mock/use the correct service moving forward. ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>
davismcphee
added a commit
to davismcphee/kibana
that referenced
this pull request
Nov 8, 2024
This reverts commit 257688d.
Merged
11 tasks
jbudz
pushed a commit
that referenced
this pull request
Nov 8, 2024
…dation errors in tests (#199539) ## Summary This PR fixes an issue introduced in #196962 where search strategy polling requests sent from some integration tests were missing necessary body parameters, resulting in validation errors and test failures. This issue was not caught by CI in the original PR because it only occurs when a search request runs slow enough to return partial results (and therefore requires polling), which is not common in test runs. Fixes #199537 Fixes #199499 Fixes #199460 Fixes #199449 Fixes #199412 Fixes #199410 Fixes #199394 Fixes #199379 Fixes #199372 Fixes #199363 Fixes #199541 Fixes #199446 Fixes #199433 Fixes #199432 Fixes #199381 Fixes #199369 Fixes #199364 Flaky test runner x200: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7362. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 11, 2024
…dation errors in tests (elastic#199539) ## Summary This PR fixes an issue introduced in elastic#196962 where search strategy polling requests sent from some integration tests were missing necessary body parameters, resulting in validation errors and test failures. This issue was not caught by CI in the original PR because it only occurs when a search request runs slow enough to return partial results (and therefore requires polling), which is not common in test runs. Fixes elastic#199537 Fixes elastic#199499 Fixes elastic#199460 Fixes elastic#199449 Fixes elastic#199412 Fixes elastic#199410 Fixes elastic#199394 Fixes elastic#199379 Fixes elastic#199372 Fixes elastic#199363 Fixes elastic#199541 Fixes elastic#199446 Fixes elastic#199433 Fixes elastic#199432 Fixes elastic#199381 Fixes elastic#199369 Fixes elastic#199364 Flaky test runner x200: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7362. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #186139.
Moves direct consumers off of the
internal/bsearchendpoint and onto theinternal/search.This is in preparation for removing the
internal/bsearchendpoint entirely.Updates automated tests to mock/use the correct service moving forward.
Checklist