[ML] Transforms: Limit the data grid result window #196510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
added
release_note:fix
:ml
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
szabosteve
reviewed
Oct 16, 2024
...s/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: István Zoltán Szabó <[email protected]>
darnautov
approved these changes
Oct 17, 2024
| @@ -288,6 +289,11 @@ export const StepDefineForm: FC<StepDefineFormProps> = React.memo((props) => { | |||
| }; | |||
| }); | |||
|
|
|||
| const rowCountInfoLabel = i18n.translate('xpack.transform.stepDefineForm.rowCountInfoLabel', { | |||
There was a problem hiding this comment.
For react components FormattedMessage component is preferred according to Kibana's guidelines
There was a problem hiding this comment.
|
Starting backport for target branches: 8.16 |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
cc @rbrtj |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
## Summary Fix for: [elastic#196101](elastic#196101) Added a limit for grid data, capping it at a max of `10000` documents, as any number above this triggers an error due to ES pagination limitations. Since this is only a preview, displaying all the data in the grid is unnecessary. After:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 592225d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…196829) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Transforms: Limit the data grid result window (#196510)](#196510) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T09:45:10Z","message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Transforms: Limit the data grid result window","number":196510,"url":"https://github.com/elastic/kibana/pull/196510","mergeCommit":{"message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196510","number":196510,"mergeCommit":{"message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
|
@rbrtj there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
rbrtj
added
v8.17.0
backport:version
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
## Summary Fix for: [elastic#196101](elastic#196101) Added a limit for grid data, capping it at a max of `10000` documents, as any number above this triggers an error due to ES pagination limitations. Since this is only a preview, displaying all the data in the grid is unnecessary. After:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: István Zoltán Szabó <[email protected]> (cherry picked from commit 592225d)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…197002) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Transforms: Limit the data grid result window (#196510)](#196510) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T09:45:10Z","message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Transforms: Limit the data grid result window","number":196510,"url":"https://github.com/elastic/kibana/pull/196510","mergeCommit":{"message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196510","number":196510,"mergeCommit":{"message":"[ML] Transforms: Limit the data grid result window (#196510)\n\n## Summary\r\n\r\nFix for: [#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a limit for grid data, capping it at a max of `10000` documents,\r\nas any number above this triggers an error due to ES pagination\r\nlimitations. Since this is only a preview, displaying all the data in\r\nthe grid is unnecessary.\r\nAfter:\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: István Zoltán Szabó <[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196829","number":196829,"state":"MERGED","mergeCommit":{"sha":"21a3625dd5933dcdc87195f5cb3bfa450a5287c9","message":"[8.16] [ML] Transforms: Limit the data grid result window (#196510) (#196829)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[ML] Transforms: Limit the data grid result window\n(#196510)](https://github.com/elastic/kibana/pull/196510)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Robert\nJaszczurek\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T09:45:10Z\",\"message\":\"[ML]\nTransforms: Limit the data grid result window (#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded a\nlimit for grid data, capping it at a max of `10000` documents,\\r\\nas any\nnumber above this triggers an error due to ES pagination\\r\\nlimitations.\nSince this is only a preview, displaying all the data in\\r\\nthe grid is\nunnecessary.\\r\\nAfter:\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [ ] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván Zoltán Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nTransforms: Limit the data grid result\nwindow\",\"number\":196510,\"url\":\"https://github.com/elastic/kibana/pull/196510\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Limit the data grid result window (#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded a\nlimit for grid data, capping it at a max of `10000` documents,\\r\\nas any\nnumber above this triggers an error due to ES pagination\\r\\nlimitations.\nSince this is only a preview, displaying all the data in\\r\\nthe grid is\nunnecessary.\\r\\nAfter:\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [ ] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván Zoltán Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196510\",\"number\":196510,\"mergeCommit\":{\"message\":\"[ML]\nTransforms: Limit the data grid result window (#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded a\nlimit for grid data, capping it at a max of `10000` documents,\\r\\nas any\nnumber above this triggers an error due to ES pagination\\r\\nlimitations.\nSince this is only a preview, displaying all the data in\\r\\nthe grid is\nunnecessary.\\r\\nAfter:\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [ ] Any text added follows [EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence case text and includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván Zoltán Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Robert Jaszczurek <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for: #196101
Added a limit for grid data, capping it at a max of
10000documents, as any number above this triggers an error due to ES pagination limitations. Since this is only a preview, displaying all the data in the grid is unnecessary.After:
Checklist