Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Error while navigating to later pages of source documents in the Transforms wizard. #196101

Closed
rbrtj opened this issue Oct 14, 2024 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience :ml v8.16.0

Comments

@rbrtj
Copy link
Contributor

rbrtj commented Oct 14, 2024

Kibana version:
9.0
Elasticsearch version:
9.0

Steps to reproduce:

  1. Create a new transform
  2. For the source documents, select the last pagination page (it should be a higher number).

Describe the bug:
Image

@rbrtj rbrtj added :ml bug Fixes for quality problems that affect the customer experience labels Oct 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

rbrtj added a commit that referenced this issue Oct 18, 2024
## Summary

Fix for: [#196101](#196101)
Added a limit for grid data, capping it at a max of `10000` documents,
as any number above this triggers an error due to ES pagination
limitations. Since this is only a preview, displaying all the data in
the grid is unnecessary.
After:
![Screenshot 2024-10-16 at 11 37
29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)



### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: István Zoltán Szabó <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 18, 2024
## Summary

Fix for: [elastic#196101](elastic#196101)
Added a limit for grid data, capping it at a max of `10000` documents,
as any number above this triggers an error due to ES pagination
limitations. Since this is only a preview, displaying all the data in
the grid is unnecessary.
After:
![Screenshot 2024-10-16 at 11 37
29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit 592225d)
@rbrtj
Copy link
Contributor Author

rbrtj commented Oct 18, 2024

Done in: #196510

@rbrtj rbrtj closed this as completed Oct 18, 2024
kibanamachine added a commit that referenced this issue Oct 18, 2024
…196829)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] Transforms: Limit the data grid result window
(#196510)](#196510)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T09:45:10Z","message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML]
Transforms: Limit the data grid result
window","number":196510,"url":"https://github.com/elastic/kibana/pull/196510","mergeCommit":{"message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196510","number":196510,"mergeCommit":{"message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
## Summary

Fix for: [elastic#196101](elastic#196101)
Added a limit for grid data, capping it at a max of `10000` documents,
as any number above this triggers an error due to ES pagination
limitations. Since this is only a preview, displaying all the data in
the grid is unnecessary.
After:
![Screenshot 2024-10-16 at 11 37
29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit 592225d)
kibanamachine added a commit that referenced this issue Oct 21, 2024
…197002)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Transforms: Limit the data grid result window
(#196510)](#196510)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T09:45:10Z","message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Transforms: Limit the data grid result
window","number":196510,"url":"https://github.com/elastic/kibana/pull/196510","mergeCommit":{"message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196510","number":196510,"mergeCommit":{"message":"[ML]
Transforms: Limit the data grid result window (#196510)\n\n##
Summary\r\n\r\nFix for:
[#196101](https://github.com/elastic/kibana/issues/196101)\r\nAdded a
limit for grid data, capping it at a max of `10000` documents,\r\nas any
number above this triggers an error due to ES pagination\r\nlimitations.
Since this is only a preview, displaying all the data in\r\nthe grid is
unnecessary.\r\nAfter:\r\n![Screenshot 2024-10-16 at 11
37\r\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by:
István Zoltán Szabó
<[email protected]>","sha":"592225dfb6ffefa2717b49479491231dec12ecf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196829","number":196829,"state":"MERGED","mergeCommit":{"sha":"21a3625dd5933dcdc87195f5cb3bfa450a5287c9","message":"[8.16]
[ML] Transforms: Limit the data grid result window (#196510)
(#196829)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [[ML] Transforms: Limit the data grid result
window\n(#196510)](https://github.com/elastic/kibana/pull/196510)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Robert\nJaszczurek\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T09:45:10Z\",\"message\":\"[ML]\nTransforms:
Limit the data grid result window
(#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix
for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded
a\nlimit for grid data, capping it at a max of `10000`
documents,\\r\\nas any\nnumber above this triggers an error due to ES
pagination\\r\\nlimitations.\nSince this is only a preview, displaying
all the data in\\r\\nthe grid
is\nunnecessary.\\r\\nAfter:\\r\\n![Screenshot 2024-10-16 at
11\n37\\r\\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n-
[ ] Any text added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván
Zoltán
Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nTransforms:
Limit the data grid
result\nwindow\",\"number\":196510,\"url\":\"https://github.com/elastic/kibana/pull/196510\",\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Limit the data grid result window
(#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix
for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded
a\nlimit for grid data, capping it at a max of `10000`
documents,\\r\\nas any\nnumber above this triggers an error due to ES
pagination\\r\\nlimitations.\nSince this is only a preview, displaying
all the data in\\r\\nthe grid
is\nunnecessary.\\r\\nAfter:\\r\\n![Screenshot 2024-10-16 at
11\n37\\r\\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n-
[ ] Any text added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván
Zoltán
Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196510\",\"number\":196510,\"mergeCommit\":{\"message\":\"[ML]\nTransforms:
Limit the data grid result window
(#196510)\\n\\n##\nSummary\\r\\n\\r\\nFix
for:\n[#196101](https://github.com/elastic/kibana/issues/196101)\\r\\nAdded
a\nlimit for grid data, capping it at a max of `10000`
documents,\\r\\nas any\nnumber above this triggers an error due to ES
pagination\\r\\nlimitations.\nSince this is only a preview, displaying
all the data in\\r\\nthe grid
is\nunnecessary.\\r\\nAfter:\\r\\n![Screenshot 2024-10-16 at
11\n37\\r\\n29](https://github.com/user-attachments/assets/f73c8169-3be7-4a27-9169-c4161b22c214)\\r\\n\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n-
[ ] Any text added follows
[EUI's\nwriting\\r\\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),\nuses\\r\\nsentence
case text and
includes\n[i18n\\r\\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nIstván
Zoltán
Szabó\n<[email protected]>\",\"sha\":\"592225dfb6ffefa2717b49479491231dec12ecf2\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Robert Jaszczurek
<[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :ml v8.16.0
Projects
None yet
Development

No branches or pull requests

3 participants