Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Adding model versions for all remaining so types without model versions (#195500) #196457

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 15, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ns (elastic#195500)

Resolves elastic#184618

## Summary

Adds v1 schemas for all remaining Response Ops owned saved object types:
* `connector_token`
* `api_key_pending_invalidation`
* `maintenance-window`
* `rules-settings`

## To Verify

1. Run ES and Kibana on `main` and create saved objects for each of the
above types:
a. Create an OAuth ServiceNow ITOM connector to create a
`connector_token` saved object
b. Create a rule, let it run, and then delete the rule. This will create
an `api_key_pending_invalidation` SO and 2 `rules-settings` SOs
  c. Create some maintenance windows, both with and without filters
2. Keep ES running and switch to this branch and restart Kibana. Then
verify you can read and modify the existing SOs with no errors
a. Test the ServiceNow ITOM connector, which should read the
`connector_token` SO
b. Modify the rules settings and then run a rule to ensure they're
loaded with no errors
  c. Load the maintenance window UI and edit a MW

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit d9cd17b)

# Conflicts:
#	src/core/server/integration_tests/ci_checks/saved_objects/check_registered_types.test.ts
@ymao1 ymao1 merged commit d5d39e5 into elastic:8.x Oct 16, 2024
32 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants