Adding model versions for all remaining so types without model versions #195500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ymao1
added
release_note:skip
|
The latest build succeeded https://buildkite.com/elastic/kibana-pull-request/builds/241597, not sure why there was no update to the PR |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@elasticmachine merge upstream |
pmuellr
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
LGTM.
Did all the tests listed, except for the SN ITOM one - I guess you can't just give it garbage? :-). Everything I tested ran fine ..., SO's now have a typeMigrationVersion of 10.1.0 - I can't remember why those numbers are the way they are, but I think that's right.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @ymao1 |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Oct 15, 2024
…ns (elastic#195500) Resolves elastic#184618 ## Summary Adds v1 schemas for all remaining Response Ops owned saved object types: * `connector_token` * `api_key_pending_invalidation` * `maintenance-window` * `rules-settings` ## To Verify 1. Run ES and Kibana on `main` and create saved objects for each of the above types: a. Create an OAuth ServiceNow ITOM connector to create a `connector_token` saved object b. Create a rule, let it run, and then delete the rule. This will create an `api_key_pending_invalidation` SO and 2 `rules-settings` SOs c. Create some maintenance windows, both with and without filters 2. Keep ES running and switch to this branch and restart Kibana. Then verify you can read and modify the existing SOs with no errors a. Test the ServiceNow ITOM connector, which should read the `connector_token` SO b. Modify the rules settings and then run a rule to ensure they're loaded with no errors c. Load the maintenance window UI and edit a MW Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit d9cd17b) # Conflicts: # src/core/server/integration_tests/ci_checks/saved_objects/check_registered_types.test.ts
ymao1
added a commit
that referenced
this pull request
Oct 16, 2024
…versions (#195500) (#196457) # Backport This will backport the following commits from `main` to `8.x`: - [Adding model versions for all remaining so types without model versions (#195500)](#195500) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T22:22:46Z","message":"Adding model versions for all remaining so types without model versions (#195500)\n\nResolves https://github.com/elastic/kibana/issues/184618\r\n\r\n## Summary\r\n\r\nAdds v1 schemas for all remaining Response Ops owned saved object types:\r\n* `connector_token`\r\n* `api_key_pending_invalidation`\r\n* `maintenance-window`\r\n* `rules-settings`\r\n\r\n## To Verify\r\n\r\n1. Run ES and Kibana on `main` and create saved objects for each of the\r\nabove types:\r\na. Create an OAuth ServiceNow ITOM connector to create a\r\n`connector_token` saved object\r\nb. Create a rule, let it run, and then delete the rule. This will create\r\nan `api_key_pending_invalidation` SO and 2 `rules-settings` SOs\r\n c. Create some maintenance windows, both with and without filters\r\n2. Keep ES running and switch to this branch and restart Kibana. Then\r\nverify you can read and modify the existing SOs with no errors\r\na. Test the ServiceNow ITOM connector, which should read the\r\n`connector_token` SO\r\nb. Modify the rules settings and then run a rule to ensure they're\r\nloaded with no errors\r\n c. Load the maintenance window UI and edit a MW\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d9cd17bdbd47d66968bd5fda6fb32a08134fbc2d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Feature:Actions","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"number":195500,"url":"https://github.com/elastic/kibana/pull/195500","mergeCommit":{"message":"Adding model versions for all remaining so types without model versions (#195500)\n\nResolves https://github.com/elastic/kibana/issues/184618\r\n\r\n## Summary\r\n\r\nAdds v1 schemas for all remaining Response Ops owned saved object types:\r\n* `connector_token`\r\n* `api_key_pending_invalidation`\r\n* `maintenance-window`\r\n* `rules-settings`\r\n\r\n## To Verify\r\n\r\n1. Run ES and Kibana on `main` and create saved objects for each of the\r\nabove types:\r\na. Create an OAuth ServiceNow ITOM connector to create a\r\n`connector_token` saved object\r\nb. Create a rule, let it run, and then delete the rule. This will create\r\nan `api_key_pending_invalidation` SO and 2 `rules-settings` SOs\r\n c. Create some maintenance windows, both with and without filters\r\n2. Keep ES running and switch to this branch and restart Kibana. Then\r\nverify you can read and modify the existing SOs with no errors\r\na. Test the ServiceNow ITOM connector, which should read the\r\n`connector_token` SO\r\nb. Modify the rules settings and then run a rule to ensure they're\r\nloaded with no errors\r\n c. Load the maintenance window UI and edit a MW\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d9cd17bdbd47d66968bd5fda6fb32a08134fbc2d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195500","number":195500,"mergeCommit":{"message":"Adding model versions for all remaining so types without model versions (#195500)\n\nResolves https://github.com/elastic/kibana/issues/184618\r\n\r\n## Summary\r\n\r\nAdds v1 schemas for all remaining Response Ops owned saved object types:\r\n* `connector_token`\r\n* `api_key_pending_invalidation`\r\n* `maintenance-window`\r\n* `rules-settings`\r\n\r\n## To Verify\r\n\r\n1. Run ES and Kibana on `main` and create saved objects for each of the\r\nabove types:\r\na. Create an OAuth ServiceNow ITOM connector to create a\r\n`connector_token` saved object\r\nb. Create a rule, let it run, and then delete the rule. This will create\r\nan `api_key_pending_invalidation` SO and 2 `rules-settings` SOs\r\n c. Create some maintenance windows, both with and without filters\r\n2. Keep ES running and switch to this branch and restart Kibana. Then\r\nverify you can read and modify the existing SOs with no errors\r\na. Test the ServiceNow ITOM connector, which should read the\r\n`connector_token` SO\r\nb. Modify the rules settings and then run a rule to ensure they're\r\nloaded with no errors\r\n c. Load the maintenance window UI and edit a MW\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d9cd17bdbd47d66968bd5fda6fb32a08134fbc2d"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184618
Summary
Adds v1 schemas for all remaining Response Ops owned saved object types:
connector_tokenapi_key_pending_invalidationmaintenance-windowrules-settingsTo Verify
mainand create saved objects for each of the above types:a. Create an OAuth ServiceNow ITOM connector to create a
connector_tokensaved objectb. Create a rule, let it run, and then delete the rule. This will create an
api_key_pending_invalidationSO and 2rules-settingsSOsc. Create some maintenance windows, both with and without filters
a. Test the ServiceNow ITOM connector, which should read the
connector_tokenSOb. Modify the rules settings and then run a rule to ensure they're loaded with no errors
c. Load the maintenance window UI and edit a MW