[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled #196387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
…-services-dont-show-without-apmmetrics-being-installed
iblancof
changed the title
…-services-dont-show-without-apmmetrics-being-installed
cauemarcondes
requested changes
Oct 16, 2024
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Outdated
Show resolved
Hide resolved
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Outdated
Show resolved
Hide resolved
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Show resolved
Hide resolved
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Show resolved
Hide resolved
...gins/observability_solution/infra/public/components/shared/templates/infra_page_template.tsx
Outdated
Show resolved
Hide resolved
…-services-dont-show-without-apmmetrics-being-installed
…-services-dont-show-without-apmmetrics-being-installed
|
Let's go ahead and merge this solution then 🚀 Here are some answers, @roshan-elastic.
Yes, service views were already handling APM signals (metrics or traces) before, and in this PR, we’re adding logs as well.
Yes, the specific inventories appear empty because no data has been detected from those sources.
Yes, that’s exactly what will happen, and the same applies to Infra. |
…-services-dont-show-without-apmmetrics-being-installed
...gins/observability_solution/infra/public/components/shared/templates/infra_page_template.tsx
Outdated
Show resolved
Hide resolved
…-services-dont-show-without-apmmetrics-being-installed
x-pack/plugins/observability_solution/infra/public/components/asset_details/template/page.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/asset_details/template/page.tsx
Outdated
Show resolved
Hide resolved
…asset_details/template/page.tsx Co-authored-by: Cauê Marcondes <[email protected]>
…-services-dont-show-without-apmmetrics-being-installed
...ck/plugins/observability_solution/infra/public/components/shared/templates/no_data_config.ts
Outdated
Show resolved
Hide resolved
…-services-dont-show-without-apmmetrics-being-installed
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @iblancof |
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…M is enabled (elastic#196387) ## Summary Closes elastic#196084. We want to show Service, Host and Container views instead of onboarging when EEM is enabled, entityCentricExperience advanced setting is enabled and the entity has logs. >[!NOTE] The visibility of the noDataConfig is evaluated at a generic template level for all 3 entity types. To manage visibility based on entity-specific information (checking for logs), we had to add checks within these templates. While this isn’t an ideal solution, it’s temporary, as we expect upcoming generic entity views will eventually allow us to remove this logic. ## Implementation details There's no need to check if EEM is enabled, as the used `dataStreams` information won’t return any results if EEM is disabled. This makes the extra check unnecessary. |Entity|Before|After| |-|-|-| |Service||| |Host/Container||| --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]> (cherry picked from commit 586330b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…M is enabled (elastic#196387) ## Summary Closes elastic#196084. We want to show Service, Host and Container views instead of onboarging when EEM is enabled, entityCentricExperience advanced setting is enabled and the entity has logs. >[!NOTE] The visibility of the noDataConfig is evaluated at a generic template level for all 3 entity types. To manage visibility based on entity-specific information (checking for logs), we had to add checks within these templates. While this isn’t an ideal solution, it’s temporary, as we expect upcoming generic entity views will eventually allow us to remove this logic. ## Implementation details There's no need to check if EEM is enabled, as the used `dataStreams` information won’t return any results if EEM is disabled. This makes the extra check unnecessary. |Entity|Before|After| |-|-|-| |Service||| |Host/Container||| --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]> (cherry picked from commit 586330b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…when EEM is enabled (#196387) (#196838) # Backport This will backport the following commits from `main` to `8.16`: - [[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)](#196387) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T10:21:48Z","message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled","number":196387,"url":"https://github.com/elastic/kibana/pull/196387","mergeCommit":{"message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196387","number":196387,"mergeCommit":{"message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…hen EEM is enabled (#196387) (#196839) # Backport This will backport the following commits from `main` to `8.x`: - [[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)](#196387) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T10:21:48Z","message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled","number":196387,"url":"https://github.com/elastic/kibana/pull/196387","mergeCommit":{"message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196387","number":196387,"mergeCommit":{"message":"[APM/Infra] Display entity detail views for logs-only signals when EEM is enabled (#196387)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/196084.\r\n\r\nWe want to show Service, Host and Container views instead of onboarging\r\nwhen EEM is enabled, entityCentricExperience advanced setting is enabled\r\nand the entity has logs.\r\n\r\n>[!NOTE]\r\nThe visibility of the noDataConfig is evaluated at a generic template\r\nlevel for all 3 entity types.\r\nTo manage visibility based on entity-specific information (checking for\r\nlogs), we had to add checks within these templates. While this isn’t an\r\nideal solution, it’s temporary, as we expect upcoming generic entity\r\nviews will eventually allow us to remove this logic.\r\n\r\n## Implementation details\r\n\r\nThere's no need to check if EEM is enabled, as the used `dataStreams`\r\ninformation won’t return any results if EEM is disabled. This makes the\r\nextra check unnecessary.\r\n\r\n|Entity|Before|After|\r\n|-|-|-|\r\n\r\n|Service|||\r\n\r\n|Host/Container|||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"586330bd0b557640faa3e019201592f67d180aa4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
iblancof
deleted the
196084-inventory-logs-only-hosts-containers--services-dont-show-without-apmmetrics-being-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #196084.
We want to show Service, Host and Container views instead of onboarging when EEM is enabled, entityCentricExperience advanced setting is enabled and the entity has logs.
Note
The visibility of the noDataConfig is evaluated at a generic template level for all 3 entity types.
To manage visibility based on entity-specific information (checking for logs), we had to add checks within these templates. While this isn’t an ideal solution, it’s temporary, as we expect upcoming generic entity views will eventually allow us to remove this logic.
Implementation details
There's no need to check if EEM is enabled, as the used
dataStreamsinformation won’t return any results if EEM is disabled. This makes the extra check unnecessary.